diff mbox series

[4/4] arm64: dts: rockchip: Enable eDP display on rk3399 evb

Message ID 20200305113912.32226-5-andy.yan@rock-chips.com (mailing list archive)
State New, archived
Headers show
Series Enable eDP display on rk3399 evb. | expand

Commit Message

Andy Yan March 5, 2020, 11:39 a.m. UTC
Add eDP panle and enable relative dt node like vop/iommu
to enable eDP display on rk3399 evb.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 40 +++++++++++++++++++++
 1 file changed, 40 insertions(+)

Comments

Heiko Stuebner March 5, 2020, 11:51 p.m. UTC | #1
Am Donnerstag, 5. März 2020, 12:39:12 CET schrieb Andy Yan:
> Add eDP panle and enable relative dt node like vop/iommu
> to enable eDP display on rk3399 evb.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

applied for 5.7 - after removing the added blank line at the end
of the file

Thanks
Heiko
Johan Jonker March 6, 2020, 7:39 a.m. UTC | #2
Hi,

Missing #address-cells, #size-cells
Can you still fix that?
Also include all email addresses that are produced by:

./scripts/get_maintainer.pl --nogit-fallback --nogit

> 
> Am Donnerstag, 5. März 2020, 12:39:12 CET schrieb Andy Yan:
>> Add eDP panle and enable relative dt node like vop/iommu
>> to enable eDP display on rk3399 evb.
>> 
>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
> 
> applied for 5.7 - after removing the added blank line at the end
> of the file
> 
> Thanks
> Heiko



> +&edp {
> +	status = "okay";
> +	force-hpd;
> +
> +	ports {

#address-cells = <1>;
#size-cells = <0>;

Don't forget that extra empty line here.

> +		edp_out: port at 1 {
> +			reg = <1>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			edp_out_panel: endpoint at 0 {
> +				reg = <0>;
> +				remote-endpoint = <&panel_in_edp>;
> +			};
> +		};
> +	};
> +};
Heiko Stuebner March 6, 2020, 9:57 a.m. UTC | #3
Hi Johan,

Am Freitag, 6. März 2020, 08:39:13 CET schrieb Johan Jonker:
> Hi,
> 
> Missing #address-cells, #size-cells
> Can you still fix that?
> Also include all email addresses that are produced by:
> 
> ./scripts/get_maintainer.pl --nogit-fallback --nogit
> 
> > 
> > Am Donnerstag, 5. März 2020, 12:39:12 CET schrieb Andy Yan:
> >> Add eDP panle and enable relative dt node like vop/iommu
> >> to enable eDP display on rk3399 evb.
> >> 
> >> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
> > 
> > applied for 5.7 - after removing the added blank line at the end
> > of the file
> > 
> > Thanks
> > Heiko
> 
> 
> 
> > +&edp {
> > +	status = "okay";
> > +	force-hpd;
> > +
> > +	ports {
> 
> #address-cells = <1>;
> #size-cells = <0>;
> 
> Don't forget that extra empty line here.

same comment as on the Pinebook pro, the #address-cells
under the ports node get inherited from the main edp node
in rk3399.dtsi

Heiko

> 
> > +		edp_out: port at 1 {
> > +			reg = <1>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			edp_out_panel: endpoint at 0 {
> > +				reg = <0>;
> > +				remote-endpoint = <&panel_in_edp>;
> > +			};
> > +		};
> > +	};
> > +};
> 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
index d4e402b40d08..23e213c421d0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts
@@ -51,6 +51,19 @@ 
 		pwms = <&pwm0 0 25000 0>;
 	};
 
+	edp_panel: edp-panel {
+		compatible ="lg,lp079qx1-sp0v";
+		backlight = <&backlight>;
+		power-supply = <&vcc3v3_s0>;
+		enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
+
+		port {
+			panel_in_edp: endpoint {
+				remote-endpoint = <&edp_out_panel>;
+			};
+		};
+	};
+
 	clkin_gmac: external-gmac-clock {
 		compatible = "fixed-clock";
 		clock-frequency = <125000000>;
@@ -113,6 +126,24 @@ 
 
 };
 
+&edp {
+	status = "okay";
+	force-hpd;
+
+	ports {
+		edp_out: port@1 {
+			reg = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			edp_out_panel: endpoint@0 {
+				reg = <0>;
+				remote-endpoint = <&panel_in_edp>;
+			};
+		};
+	};
+};
+
 &emmc_phy {
 	status = "okay";
 };
@@ -439,3 +470,12 @@ 
 		};
 	};
 };
+
+&vopb {
+	status = "okay";
+};
+
+&vopb_mmu {
+	status = "okay";
+};
+