diff mbox series

ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload

Message ID 20200314140755.4877-1-jbx6244@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: rockchip: fix vref-supply for &saradc node rk3288 firefly reload | expand

Commit Message

Johan Jonker March 14, 2020, 2:07 p.m. UTC
A test with the command below gives this error:

arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml: saradc@ff100000:
'vref-supply' is a required property

PMIC Channel OUT11 with powername 'vcc_18'
(connected through R155 bridge with 'vccio_wl')
is used for the recovery key and ADC_AVDD_1V8.

Fix error by adding 'vcc_18' as vref for the saradc.

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/
rockchip-saradc.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Schematic:

http://www.t-firefly.com/download/Firefly-RK3288-Reload/hardware/MainBoard/
Schematic/FIREFLY-RK3288_RELOAD_V10_Schematic.pdf
---
 arch/arm/boot/dts/rk3288-firefly-reload.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stuebner March 17, 2020, 12:26 a.m. UTC | #1
Am Samstag, 14. März 2020, 15:07:55 CET schrieb Johan Jonker:
> A test with the command below gives this error:
> 
> arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml: saradc@ff100000:
> 'vref-supply' is a required property
> 
> PMIC Channel OUT11 with powername 'vcc_18'
> (connected through R155 bridge with 'vccio_wl')
> is used for the recovery key and ADC_AVDD_1V8.
> 
> Fix error by adding 'vcc_18' as vref for the saradc.
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/
> rockchip-saradc.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

applied for 5.7

Thanks
Heiko
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts b/arch/arm/boot/dts/rk3288-firefly-reload.dts
index 1574383fd..8c38bda21 100644
--- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
+++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
@@ -234,6 +234,7 @@ 
 };
 
 &saradc {
+	vref-supply = <&vcc_18>;
 	status = "okay";
 };