| Message ID | 20200401213721.24173-3-ezequiel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rockchip ISP1 minor fixes | expand |
On 4/1/20 6:37 PM, Ezequiel Garcia wrote: > The driver is perfectly capable of being built without CONFIG_OF. > Remove this dependency, which is useful for compile-only tests. > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> > --- > drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > index bd0147624de1..fb74df829371 100644 > --- a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > +++ b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > @@ -2,7 +2,7 @@ > > config PHY_ROCKCHIP_DPHY_RX0 > tristate "Rockchip MIPI Synopsys DPHY RX0 driver" > - depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > + depends on ARCH_ROCKCHIP || COMPILE_TEST > select GENERIC_PHY_MIPI_DPHY > select GENERIC_PHY > help >
On Thu, 2020-04-02 at 10:59 -0300, Helen Koike wrote: > > On 4/1/20 6:37 PM, Ezequiel Garcia wrote: > > The driver is perfectly capable of being built without CONFIG_OF. > > Remove this dependency, which is useful for compile-only tests. > > > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> > > Acked-by: Helen Koike <helen.koike@collabora.com> > > > --- > > drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > > index bd0147624de1..fb74df829371 100644 > > --- a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > > +++ b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig > > @@ -2,7 +2,7 @@ > > > > config PHY_ROCKCHIP_DPHY_RX0 > > tristate "Rockchip MIPI Synopsys DPHY RX0 driver" > > - depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > > + depends on ARCH_ROCKCHIP || COMPILE_TEST After discussing other similar patches, I'm starting to think this was a bad idea. Instead, we want to do have (ARCH_ROCKCHIP && OF) || COMPILE_TEST as the other Rockchip PHYs. Thanks, Ezequiel
diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig index bd0147624de1..fb74df829371 100644 --- a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig +++ b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig @@ -2,7 +2,7 @@ config PHY_ROCKCHIP_DPHY_RX0 tristate "Rockchip MIPI Synopsys DPHY RX0 driver" - depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF + depends on ARCH_ROCKCHIP || COMPILE_TEST select GENERIC_PHY_MIPI_DPHY select GENERIC_PHY help
The driver is perfectly capable of being built without CONFIG_OF. Remove this dependency, which is useful for compile-only tests. Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com> --- drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)