Message ID | 20200402000234.226466-2-helen.koike@collabora.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 | expand |
Hi Helen, > # SPDX-License-Identifier: (GPL-2.0+ OR MIT) > %YAML 1.2 > --- > $id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx0.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings > > maintainers: > - Helen Koike <helen.koike@collabora.com> > - Ezequiel Garcia <ezequiel@collabora.com> > > description: | > The Rockchip SoC has a MIPI D-PHY bus with an RX0 entry which connects to > the ISP1 (Image Signal Processing unit v1.0) for CSI cameras. > > properties: > compatible: > const: rockchip,rk3399-mipi-dphy-rx0 > > reg: > maxItems: 1 If 'reg' is not used => remove it. > > clocks: > items: > - description: MIPI D-PHY ref clock > - description: MIPI D-PHY RX0 cfg clock > - description: Video in/out general register file clock > > clock-names: > items: > - const: dphy-ref > - const: dphy-cfg > - const: grf > > '#phy-cells': > const: 0 > > power-domains: > description: Video in/out power domain. > maxItems: 1 > > required: > - compatible > - clocks > - clock-names > - '#phy-cells' > - power-domains > > additionalProperties: false > > examples: > - | > > /* > * MIPI D-PHY RX0 use registers in "general register files", it > * should be a child of the GRF. > * > * grf: syscon@ff770000 { > * compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; > * ... > * }; > */ > > #include <dt-bindings/clock/rk3399-cru.h> > #include <dt-bindings/power/rk3399-power.h> > > mipi_dphy_rx0: mipi-dphy-rx0 { > compatible = "rockchip,rk3399-mipi-dphy-rx0"; > clocks = <&cru SCLK_MIPIDPHY_REF>, > <&cru SCLK_DPHY_RX0_CFG>, > <&cru PCLK_VIO_GRF>; > clock-names = "dphy-ref", "dphy-cfg", "grf"; > power-domains = <&power RK3399_PD_VIO>; > #phy-cells = <0>; > };
Hi Johan, On 4/2/20 9:16 AM, Johan Jonker wrote: > Hi Helen, > >> # SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> %YAML 1.2 >> --- >> $id: http://devicetree.org/schemas/phy/rockchip-mipi-dphy-rx0.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> title: Rockchip SoC MIPI RX0 D-PHY Device Tree Bindings >> >> maintainers: >> - Helen Koike <helen.koike@collabora.com> >> - Ezequiel Garcia <ezequiel@collabora.com> >> >> description: | >> The Rockchip SoC has a MIPI D-PHY bus with an RX0 entry which connects to >> the ISP1 (Image Signal Processing unit v1.0) for CSI cameras. >> >> properties: >> compatible: >> const: rockchip,rk3399-mipi-dphy-rx0 >> > >> reg: >> maxItems: 1 > > If 'reg' is not used => remove it. ok, I'll add a patch removing it. Thanks, Helen > >> >> clocks: >> items: >> - description: MIPI D-PHY ref clock >> - description: MIPI D-PHY RX0 cfg clock >> - description: Video in/out general register file clock >> >> clock-names: >> items: >> - const: dphy-ref >> - const: dphy-cfg >> - const: grf >> >> '#phy-cells': >> const: 0 >> >> power-domains: >> description: Video in/out power domain. >> maxItems: 1 >> >> required: >> - compatible >> - clocks >> - clock-names >> - '#phy-cells' >> - power-domains >> >> additionalProperties: false >> >> examples: >> - | >> >> /* >> * MIPI D-PHY RX0 use registers in "general register files", it >> * should be a child of the GRF. >> * >> * grf: syscon@ff770000 { >> * compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; >> * ... >> * }; >> */ >> >> #include <dt-bindings/clock/rk3399-cru.h> >> #include <dt-bindings/power/rk3399-power.h> >> >> mipi_dphy_rx0: mipi-dphy-rx0 { >> compatible = "rockchip,rk3399-mipi-dphy-rx0"; >> clocks = <&cru SCLK_MIPIDPHY_REF>, >> <&cru SCLK_DPHY_RX0_CFG>, >> <&cru PCLK_VIO_GRF>; >> clock-names = "dphy-ref", "dphy-cfg", "grf"; >> power-domains = <&power RK3399_PD_VIO>; >> #phy-cells = <0>; >> };
(+Kishon) Hi Helen, I was wondering if we couldn't also move the phy driver out of staging. Thanks, Ezequiel On Wed, 2020-04-01 at 21:02 -0300, Helen Koike wrote: > Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy > > Signed-off-by: Helen Koike <helen.koike@collabora.com> > --- > .../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename {drivers/staging/media/phy-rockchip-dphy-rx0/Documentation => Documentation}/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml (100%) > > diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > b/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > similarity index 100% > rename from drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > rename to Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
On 4/2/20 1:17 PM, Ezequiel Garcia wrote: > (+Kishon) > > Hi Helen, > > I was wondering if we couldn't also move the phy driver out of staging. I think we can, let's move it. Regards, Helen > > Thanks, > Ezequiel > > On Wed, 2020-04-01 at 21:02 -0300, Helen Koike wrote: >> Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy >> >> Signed-off-by: Helen Koike <helen.koike@collabora.com> >> --- >> .../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> rename {drivers/staging/media/phy-rockchip-dphy-rx0/Documentation => Documentation}/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml (100%) >> >> diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml >> b/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml >> similarity index 100% >> rename from drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml >> rename to Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml > > >
diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml b/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
similarity index 100%
rename from drivers/staging/media/phy-rockchip-dphy-rx0/Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
rename to Documentation/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml
Move phy-rockchip-dphy-rx0 bindings to Documentation/devicetree/bindings/phy Signed-off-by: Helen Koike <helen.koike@collabora.com> --- .../devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {drivers/staging/media/phy-rockchip-dphy-rx0/Documentation => Documentation}/devicetree/bindings/phy/rockchip-mipi-dphy-rx0.yaml (100%)