Message ID | 20200817031114.6107-2-travelvia@airmail.cc (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v2,1/4] Documentation: bindings: usb: add rk3328 dwc3 docs | expand |
On 2020-08-17 04:11, travelvia@airmail.cc wrote: > From: Cameron Nemo <cnemo@tutanota.com> > > Add a compatible to be hooked into by the Rockchip rk3328 device tree. > > The rk3399 compatible cannot be reused because the rk3328 SoCs may > require a specialized driver in the future, and old device trees must > remain compatible with newer kernels. > > Signed-off-by: Cameron Nemo <cnemo@tutanota.com> > --- > drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c > index 7df115012935..68d6e4fa0c6a 100644 > --- a/drivers/usb/dwc3/dwc3-of-simple.c > +++ b/drivers/usb/dwc3/dwc3-of-simple.c > @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) > * Some controllers need to toggle the usb3-otg reset before trying to > * initialize the PHY, otherwise the PHY times out. > */ > - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3")) > + if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") || Is this necessary? Even downstream there's no reset control in the DT, so I can't see that it achieves anything. Robin. > + of_device_is_compatible(np, "rockchip,rk3399-dwc3")) > simple->need_reset = true; > > simple->resets = of_reset_control_array_get(np, false, true, > @@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { > }; > > static const struct of_device_id of_dwc3_simple_match[] = { > + { .compatible = "rockchip,rk3328-dwc3" }, > { .compatible = "rockchip,rk3399-dwc3" }, > { .compatible = "xlnx,zynqmp-dwc3" }, > { .compatible = "cavium,octeon-7130-usb-uctl" }, >
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 7df115012935..68d6e4fa0c6a 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers/usb/dwc3/dwc3-of-simple.c @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) * Some controllers need to toggle the usb3-otg reset before trying to * initialize the PHY, otherwise the PHY times out. */ - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3")) + if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") || + of_device_is_compatible(np, "rockchip,rk3399-dwc3")) simple->need_reset = true; simple->resets = of_reset_control_array_get(np, false, true, @@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { }; static const struct of_device_id of_dwc3_simple_match[] = { + { .compatible = "rockchip,rk3328-dwc3" }, { .compatible = "rockchip,rk3399-dwc3" }, { .compatible = "xlnx,zynqmp-dwc3" }, { .compatible = "cavium,octeon-7130-usb-uctl" },