diff mbox series

[v4,4/8] board: engicam: Attach i.MX6 common code

Message ID 20201028133348.241839-5-jagan@amarulasolutions.com (mailing list archive)
State New, archived
Headers show
Series rockchip: Add Engicam PX30.Core support | expand

Commit Message

Jagan Teki Oct. 28, 2020, 1:33 p.m. UTC 
The existing common code for Engicam boards uses i.MX6,
so attach that into i.MX6 Engicam boards so-that adding
new SoC variants of Engicam boards become meaningful.

Add support for it.

Cc: Stefano Babic <sbabic@denx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- none

 board/engicam/common/Kconfig  | 8 ++++++++
 board/engicam/common/Makefile | 7 +++++--
 board/engicam/imx6q/Kconfig   | 2 ++
 board/engicam/imx6ul/Kconfig  | 2 ++
 4 files changed, 17 insertions(+), 2 deletions(-)
 create mode 100644 board/engicam/common/Kconfig

Comments

Kever Yang Oct. 30, 2020, 3:27 p.m. UTC | #1 
On 2020/10/28 下午9:33, Jagan Teki wrote:
> The existing common code for Engicam boards uses i.MX6,
> so attach that into i.MX6 Engicam boards so-that adding
> new SoC variants of Engicam boards become meaningful.
>
> Add support for it.
>
> Cc: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
> Changes for v4:
> - none
>
>   board/engicam/common/Kconfig  | 8 ++++++++
>   board/engicam/common/Makefile | 7 +++++--
>   board/engicam/imx6q/Kconfig   | 2 ++
>   board/engicam/imx6ul/Kconfig  | 2 ++
>   4 files changed, 17 insertions(+), 2 deletions(-)
>   create mode 100644 board/engicam/common/Kconfig
>
> diff --git a/board/engicam/common/Kconfig b/board/engicam/common/Kconfig
> new file mode 100644
> index 0000000000..38328fd5ea
> --- /dev/null
> +++ b/board/engicam/common/Kconfig
> @@ -0,0 +1,8 @@
> +config IMX6_ENGICAM_COMMON
> +	bool "Engicam i.MX6 Common code"
> +	depends on SPL && MX6
> +	default y if TARGET_MX6Q_ENGICAM || TARGET_MX6UL_ENGICAM
> +	help
> +	  Common SPL and U-Boot proper code for Engicam i.MX6 targets.
> +
> +	  Enable it in board Kconfig if it uses i.MX6 variant Engicam boards.
> diff --git a/board/engicam/common/Makefile b/board/engicam/common/Makefile
> index b392bf6cb1..15f0eaa1ec 100644
> --- a/board/engicam/common/Makefile
> +++ b/board/engicam/common/Makefile
> @@ -1,5 +1,8 @@
>   # SPDX-License-Identifier: GPL-2.0+
>   # Copyright (C) 2016 Amarula Solutions B.V.
>   
> -obj-y := board.o
> -obj-$(CONFIG_SPL_BUILD) += spl.o
> +ifdef CONFIG_SPL_BUILD
> +obj-$(CONFIG_IMX6_ENGICAM_COMMON) += spl.o
> +else
> +obj-$(CONFIG_IMX6_ENGICAM_COMMON) += board.o
> +endif
> diff --git a/board/engicam/imx6q/Kconfig b/board/engicam/imx6q/Kconfig
> index 48eb60c09a..fab8da0e73 100644
> --- a/board/engicam/imx6q/Kconfig
> +++ b/board/engicam/imx6q/Kconfig
> @@ -9,4 +9,6 @@ config SYS_VENDOR
>   config SYS_CONFIG_NAME
>   	default "imx6-engicam"
>   
> +source "board/engicam/common/Kconfig"
> +
>   endif
> diff --git a/board/engicam/imx6ul/Kconfig b/board/engicam/imx6ul/Kconfig
> index e91dd15970..58f25d0623 100644
> --- a/board/engicam/imx6ul/Kconfig
> +++ b/board/engicam/imx6ul/Kconfig
> @@ -9,4 +9,6 @@ config SYS_VENDOR
>   config SYS_CONFIG_NAME
>   	default "imx6-engicam"
>   
> +source "board/engicam/common/Kconfig"
> +
>   endif
diff mbox series

Patch

diff --git a/board/engicam/common/Kconfig b/board/engicam/common/Kconfig
new file mode 100644
index 0000000000..38328fd5ea
--- /dev/null
+++ b/board/engicam/common/Kconfig
@@ -0,0 +1,8 @@ 
+config IMX6_ENGICAM_COMMON
+	bool "Engicam i.MX6 Common code"
+	depends on SPL && MX6
+	default y if TARGET_MX6Q_ENGICAM || TARGET_MX6UL_ENGICAM
+	help
+	  Common SPL and U-Boot proper code for Engicam i.MX6 targets.
+
+	  Enable it in board Kconfig if it uses i.MX6 variant Engicam boards.
diff --git a/board/engicam/common/Makefile b/board/engicam/common/Makefile
index b392bf6cb1..15f0eaa1ec 100644
--- a/board/engicam/common/Makefile
+++ b/board/engicam/common/Makefile
@@ -1,5 +1,8 @@ 
 # SPDX-License-Identifier: GPL-2.0+
 # Copyright (C) 2016 Amarula Solutions B.V.
 
-obj-y := board.o
-obj-$(CONFIG_SPL_BUILD) += spl.o
+ifdef CONFIG_SPL_BUILD
+obj-$(CONFIG_IMX6_ENGICAM_COMMON) += spl.o
+else
+obj-$(CONFIG_IMX6_ENGICAM_COMMON) += board.o
+endif
diff --git a/board/engicam/imx6q/Kconfig b/board/engicam/imx6q/Kconfig
index 48eb60c09a..fab8da0e73 100644
--- a/board/engicam/imx6q/Kconfig
+++ b/board/engicam/imx6q/Kconfig
@@ -9,4 +9,6 @@  config SYS_VENDOR
 config SYS_CONFIG_NAME
 	default "imx6-engicam"
 
+source "board/engicam/common/Kconfig"
+
 endif
diff --git a/board/engicam/imx6ul/Kconfig b/board/engicam/imx6ul/Kconfig
index e91dd15970..58f25d0623 100644
--- a/board/engicam/imx6ul/Kconfig
+++ b/board/engicam/imx6ul/Kconfig
@@ -9,4 +9,6 @@  config SYS_VENDOR
 config SYS_CONFIG_NAME
 	default "imx6-engicam"
 
+source "board/engicam/common/Kconfig"
+
 endif