| Message ID | 20201127090551.50254-1-vulab@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: rockchip: Remove redundant null check before clk_prepare_enable | expand |
Quoting Xu Wang (2020-11-27 01:05:51) > Because clk_prepare_enable() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
On Fri, 27 Nov 2020 09:05:51 +0000, Xu Wang wrote: > Because clk_prepare_enable() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. Applied, thanks! [1/1] clk: rockchip: Remove redundant null check before clk_prepare_enable commit: 7f5b57a095f3b9532793d143655e83433bb448af Best regards,
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c index b443169dd408..336481bc6cc7 100644 --- a/drivers/clk/rockchip/clk.c +++ b/drivers/clk/rockchip/clk.c @@ -603,8 +603,7 @@ void rockchip_clk_protect_critical(const char *const clocks[], for (i = 0; i < nclocks; i++) { struct clk *clk = __clk_lookup(clocks[i]); - if (clk) - clk_prepare_enable(clk); + clk_prepare_enable(clk); } } EXPORT_SYMBOL_GPL(rockchip_clk_protect_critical);
Because clk_prepare_enable() already checked NULL clock parameter, so the additional check is unnecessary, just remove it. Signed-off-by: Xu Wang <vulab@iscas.ac.cn> --- drivers/clk/rockchip/clk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)