diff mbox series

[1/8] dt-binding: watchdog: add more Rockchip compatibles to snps, dw-wdt.yaml

Message ID 20201218120534.13788-1-jbx6244@gmail.com (mailing list archive)
State New
Headers show
Series [1/8] dt-binding: watchdog: add more Rockchip compatibles to snps, dw-wdt.yaml | expand

Commit Message

Johan Jonker Dec. 18, 2020, 12:05 p.m. UTC
The watchdog compatible strings are suppose to be SoC orientated.
In the more recently added Rockchip SoC dtsi files only
the fallback string "snps,dw-wdt" is used, so add the following
compatible strings:

"rockchip,px30-wdt", "snps,dw-wdt"
"rockchip,rk3228-wdt", "snps,dw-wdt"
"rockchip,rk3308-wdt", "snps,dw-wdt"
"rockchip,rk3328-wdt", "snps,dw-wdt"
"rockchip,rk3399-wdt", "snps,dw-wdt"
"rockchip,rv1108-wdt", "snps,dw-wdt"

make ARCH=arm dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Dec. 31, 2020, 7:16 p.m. UTC | #1
On Fri, 18 Dec 2020 13:05:27 +0100, Johan Jonker wrote:
> The watchdog compatible strings are suppose to be SoC orientated.
> In the more recently added Rockchip SoC dtsi files only
> the fallback string "snps,dw-wdt" is used, so add the following
> compatible strings:
> 
> "rockchip,px30-wdt", "snps,dw-wdt"
> "rockchip,rk3228-wdt", "snps,dw-wdt"
> "rockchip,rk3308-wdt", "snps,dw-wdt"
> "rockchip,rk3328-wdt", "snps,dw-wdt"
> "rockchip,rk3399-wdt", "snps,dw-wdt"
> "rockchip,rv1108-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Heiko Stübner Jan. 9, 2021, 2:05 p.m. UTC | #2
Am Freitag, 18. Dezember 2020, 13:05:27 CET schrieb Johan Jonker:
> The watchdog compatible strings are suppose to be SoC orientated.
> In the more recently added Rockchip SoC dtsi files only
> the fallback string "snps,dw-wdt" is used, so add the following
> compatible strings:
> 
> "rockchip,px30-wdt", "snps,dw-wdt"
> "rockchip,rk3228-wdt", "snps,dw-wdt"
> "rockchip,rk3308-wdt", "snps,dw-wdt"
> "rockchip,rk3328-wdt", "snps,dw-wdt"
> "rockchip,rk3399-wdt", "snps,dw-wdt"
> "rockchip,rv1108-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

I'd like to pick up the devicetree patches (2-8) once this has landed
in the watchdog tree.

Thanks
Heiko
Guenter Roeck Jan. 23, 2021, 5:34 p.m. UTC | #3
On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> The watchdog compatible strings are suppose to be SoC orientated.
> In the more recently added Rockchip SoC dtsi files only
> the fallback string "snps,dw-wdt" is used, so add the following
> compatible strings:
> 
> "rockchip,px30-wdt", "snps,dw-wdt"
> "rockchip,rk3228-wdt", "snps,dw-wdt"
> "rockchip,rk3308-wdt", "snps,dw-wdt"
> "rockchip,rk3328-wdt", "snps,dw-wdt"
> "rockchip,rk3399-wdt", "snps,dw-wdt"
> "rockchip,rv1108-wdt", "snps,dw-wdt"
> 
> make ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index f7ee9229c..b58596b18 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -18,10 +18,16 @@ properties:
>        - const: snps,dw-wdt
>        - items:
>            - enum:
> +              - rockchip,px30-wdt
>                - rockchip,rk3066-wdt
>                - rockchip,rk3188-wdt
> +              - rockchip,rk3228-wdt
>                - rockchip,rk3288-wdt
> +              - rockchip,rk3308-wdt
> +              - rockchip,rk3328-wdt
>                - rockchip,rk3368-wdt
> +              - rockchip,rk3399-wdt
> +              - rockchip,rv1108-wdt
>            - const: snps,dw-wdt
>  
>    reg:
Heiko Stübner Jan. 25, 2021, 11:40 p.m. UTC | #4
Hi Guenter,

Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> > The watchdog compatible strings are suppose to be SoC orientated.
> > In the more recently added Rockchip SoC dtsi files only
> > the fallback string "snps,dw-wdt" is used, so add the following
> > compatible strings:
> > 
> > "rockchip,px30-wdt", "snps,dw-wdt"
> > "rockchip,rk3228-wdt", "snps,dw-wdt"
> > "rockchip,rk3308-wdt", "snps,dw-wdt"
> > "rockchip,rk3328-wdt", "snps,dw-wdt"
> > "rockchip,rk3399-wdt", "snps,dw-wdt"
> > "rockchip,rv1108-wdt", "snps,dw-wdt"
> > 
> > make ARCH=arm dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > 
> > make ARCH=arm64 dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > 
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

just to clarify, do you expect me to pick up the dt-binding patch
with the devicetree patches or do you want to take this individual
patch through the watchdog tree instead?


Thanks
Heiko

> > ---
> >  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > index f7ee9229c..b58596b18 100644
> > --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> > @@ -18,10 +18,16 @@ properties:
> >        - const: snps,dw-wdt
> >        - items:
> >            - enum:
> > +              - rockchip,px30-wdt
> >                - rockchip,rk3066-wdt
> >                - rockchip,rk3188-wdt
> > +              - rockchip,rk3228-wdt
> >                - rockchip,rk3288-wdt
> > +              - rockchip,rk3308-wdt
> > +              - rockchip,rk3328-wdt
> >                - rockchip,rk3368-wdt
> > +              - rockchip,rk3399-wdt
> > +              - rockchip,rv1108-wdt
> >            - const: snps,dw-wdt
> >  
> >    reg:
>
Guenter Roeck Jan. 26, 2021, 4:55 a.m. UTC | #5
Hi Heiko,

On 1/25/21 3:40 PM, Heiko Stuebner wrote:
> Hi Guenter,
> 
> Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
>> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
>>> The watchdog compatible strings are suppose to be SoC orientated.
>>> In the more recently added Rockchip SoC dtsi files only
>>> the fallback string "snps,dw-wdt" is used, so add the following
>>> compatible strings:
>>>
>>> "rockchip,px30-wdt", "snps,dw-wdt"
>>> "rockchip,rk3228-wdt", "snps,dw-wdt"
>>> "rockchip,rk3308-wdt", "snps,dw-wdt"
>>> "rockchip,rk3328-wdt", "snps,dw-wdt"
>>> "rockchip,rk3399-wdt", "snps,dw-wdt"
>>> "rockchip,rv1108-wdt", "snps,dw-wdt"
>>>
>>> make ARCH=arm dtbs_check
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>
>>> make ARCH=arm64 dtbs_check
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>
>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> just to clarify, do you expect me to pick up the dt-binding patch
> with the devicetree patches or do you want to take this individual
> patch through the watchdog tree instead?
> 

You'd have to ask Wim since he takes care of actually sending pull requests.
But didn't you say earlier that you wanted to apply the rest of the series
after this one is applied through the watchdog tree ?

Thanks,
Guenter

> 
> Thanks
> Heiko
> 
>>> ---
>>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> index f7ee9229c..b58596b18 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> @@ -18,10 +18,16 @@ properties:
>>>        - const: snps,dw-wdt
>>>        - items:
>>>            - enum:
>>> +              - rockchip,px30-wdt
>>>                - rockchip,rk3066-wdt
>>>                - rockchip,rk3188-wdt
>>> +              - rockchip,rk3228-wdt
>>>                - rockchip,rk3288-wdt
>>> +              - rockchip,rk3308-wdt
>>> +              - rockchip,rk3328-wdt
>>>                - rockchip,rk3368-wdt
>>> +              - rockchip,rk3399-wdt
>>> +              - rockchip,rv1108-wdt
>>>            - const: snps,dw-wdt
>>>  
>>>    reg:
>>
> 
> 
> 
>
Heiko Stübner Jan. 26, 2021, 8:37 a.m. UTC | #6
Hi Guenter,

Am Dienstag, 26. Januar 2021, 05:55:59 CET schrieb Guenter Roeck:
> On 1/25/21 3:40 PM, Heiko Stuebner wrote:
> > Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
> >> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> >>> The watchdog compatible strings are suppose to be SoC orientated.
> >>> In the more recently added Rockchip SoC dtsi files only
> >>> the fallback string "snps,dw-wdt" is used, so add the following
> >>> compatible strings:
> >>>
> >>> "rockchip,px30-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3228-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3308-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3328-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3399-wdt", "snps,dw-wdt"
> >>> "rockchip,rv1108-wdt", "snps,dw-wdt"
> >>>
> >>> make ARCH=arm dtbs_check
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>>
> >>> make ARCH=arm64 dtbs_check
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>>
> >>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> >>> Acked-by: Rob Herring <robh@kernel.org>
> >>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> >>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > just to clarify, do you expect me to pick up the dt-binding patch
> > with the devicetree patches or do you want to take this individual
> > patch through the watchdog tree instead?
> > 
> 
> You'd have to ask Wim since he takes care of actually sending pull requests.
> But didn't you say earlier that you wanted to apply the rest of the series
> after this one is applied through the watchdog tree ?

Yep that was my intent, though somehow I mistook you as also being
a watchdog maintainer, hence the confusion.

So I'll wait for Wim to apply this patch and then I'll take the rest of
the series.

Thanks
Heiko


> >>> ---
> >>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
> >>>  1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> index f7ee9229c..b58596b18 100644
> >>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> @@ -18,10 +18,16 @@ properties:
> >>>        - const: snps,dw-wdt
> >>>        - items:
> >>>            - enum:
> >>> +              - rockchip,px30-wdt
> >>>                - rockchip,rk3066-wdt
> >>>                - rockchip,rk3188-wdt
> >>> +              - rockchip,rk3228-wdt
> >>>                - rockchip,rk3288-wdt
> >>> +              - rockchip,rk3308-wdt
> >>> +              - rockchip,rk3328-wdt
> >>>                - rockchip,rk3368-wdt
> >>> +              - rockchip,rk3399-wdt
> >>> +              - rockchip,rv1108-wdt
> >>>            - const: snps,dw-wdt
> >>>  
> >>>    reg:
> >>
> > 
> > 
> > 
> > 
> 
>
Guenter Roeck Jan. 26, 2021, 2:56 p.m. UTC | #7
On 1/26/21 12:37 AM, Heiko Stübner wrote:
> Hi Guenter,
> 
> Am Dienstag, 26. Januar 2021, 05:55:59 CET schrieb Guenter Roeck:
>> On 1/25/21 3:40 PM, Heiko Stuebner wrote:
>>> Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
>>>> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
>>>>> The watchdog compatible strings are suppose to be SoC orientated.
>>>>> In the more recently added Rockchip SoC dtsi files only
>>>>> the fallback string "snps,dw-wdt" is used, so add the following
>>>>> compatible strings:
>>>>>
>>>>> "rockchip,px30-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3228-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3308-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3328-wdt", "snps,dw-wdt"
>>>>> "rockchip,rk3399-wdt", "snps,dw-wdt"
>>>>> "rockchip,rv1108-wdt", "snps,dw-wdt"
>>>>>
>>>>> make ARCH=arm dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>>
>>>>> make ARCH=arm64 dtbs_check
>>>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>>
>>>>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>>>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> just to clarify, do you expect me to pick up the dt-binding patch
>>> with the devicetree patches or do you want to take this individual
>>> patch through the watchdog tree instead?
>>>
>>
>> You'd have to ask Wim since he takes care of actually sending pull requests.
>> But didn't you say earlier that you wanted to apply the rest of the series
>> after this one is applied through the watchdog tree ?
> 
> Yep that was my intent, though somehow I mistook you as also being
> a watchdog maintainer, hence the confusion.
> 

I am, but Wim sends all pull requests.

Guenter

> So I'll wait for Wim to apply this patch and then I'll take the rest of
> the series.
> 
> Thanks
> Heiko
> 
> 
>>>>> ---
>>>>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
>>>>>  1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>> index f7ee9229c..b58596b18 100644
>>>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>>>> @@ -18,10 +18,16 @@ properties:
>>>>>        - const: snps,dw-wdt
>>>>>        - items:
>>>>>            - enum:
>>>>> +              - rockchip,px30-wdt
>>>>>                - rockchip,rk3066-wdt
>>>>>                - rockchip,rk3188-wdt
>>>>> +              - rockchip,rk3228-wdt
>>>>>                - rockchip,rk3288-wdt
>>>>> +              - rockchip,rk3308-wdt
>>>>> +              - rockchip,rk3328-wdt
>>>>>                - rockchip,rk3368-wdt
>>>>> +              - rockchip,rk3399-wdt
>>>>> +              - rockchip,rv1108-wdt
>>>>>            - const: snps,dw-wdt
>>>>>  
>>>>>    reg:
>>>>
>>>
>>>
>>>
>>>
>>
>>
> 
> 
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
index f7ee9229c..b58596b18 100644
--- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
@@ -18,10 +18,16 @@  properties:
       - const: snps,dw-wdt
       - items:
           - enum:
+              - rockchip,px30-wdt
               - rockchip,rk3066-wdt
               - rockchip,rk3188-wdt
+              - rockchip,rk3228-wdt
               - rockchip,rk3288-wdt
+              - rockchip,rk3308-wdt
+              - rockchip,rk3328-wdt
               - rockchip,rk3368-wdt
+              - rockchip,rk3399-wdt
+              - rockchip,rv1108-wdt
           - const: snps,dw-wdt
 
   reg: