From patchwork Mon Jan 18 11:04:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 12026977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94702C433E0 for ; Mon, 18 Jan 2021 11:05:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF10A221F8 for ; Mon, 18 Jan 2021 11:05:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF10A221F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EJCc9ARUBsJwFzPN5wmAUqiBGXXOgsX+J5yVsaBYHf0=; b=SF7hRKxULN3PknIrwPqMmMZdL b/JXdmOKCUjhskbpi5kCJqQsvPnk1H3Ftbac0bikMie5UBEFD1nDRi+/Hb5nrIsEjlOs/prZ1RnzL OdlBETVsjo8upbnR+6Ktz/y4t1J97tgAfz6VmDe24u5saabTQtVE8rC80hv9oc4ZIUKoZTEyixlDO UT5blx2wSNGP1nmBXov3+/iVQSeytUqe7caArZaWIb62P7Qwh5m/ZhxxgJKXe/IVi1A3kJ+dGI5XY 3Q13dXf05JP7sDO2Y6OWgyIxa9lFApBHHfn/gsJLLtj2pu3Tuqfn7Mdockt57cdXEJy8ImGKrva2W OfyjFMVXQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1SLN-0002sJ-8y; Mon, 18 Jan 2021 11:05:09 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1SLF-0002qP-Vs for linux-rockchip@lists.infradead.org; Mon, 18 Jan 2021 11:05:07 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1SL4-0003HM-JQ; Mon, 18 Jan 2021 12:04:50 +0100 From: Heiko Stuebner To: dafna.hirschfeld@collabora.com, helen.koike@collabora.com, linux-media@vger.kernel.org, mchehab@kernel.org, Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl Subject: [PATCH v6 1/4] media: rockchip: rkisp1: fix comment about number of histogram sub-windows Date: Mon, 18 Jan 2021 12:04:45 +0100 Message-Id: <20210118110448.275389-2-heiko@sntech.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210118110448.275389-1-heiko@sntech.de> References: <20210118110448.275389-1-heiko@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_060502_079700_E677BF45 X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: heiko@sntech.de, Heiko Stuebner , tfiga@chromium.org, linux-rockchip@lists.infradead.org, ezequiel@collabora.com, christoph.muellner@theobroma-systems.com Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Heiko Stuebner The histogram data is divided into 16 sub-windows, not 25. See RKISP1_CIF_ISP_HIST_BIN_N_MAX being defined as 16 for reference and this also matches the datasheet. Signed-off-by: Heiko Stuebner Acked-by: Helen Koike --- include/uapi/linux/rkisp1-config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h index 6e449e784260..ba443771cc0b 100644 --- a/include/uapi/linux/rkisp1-config.h +++ b/include/uapi/linux/rkisp1-config.h @@ -846,7 +846,7 @@ struct rkisp1_cif_isp_af_stat { * * @hist_bins: measured bin counters * - * Measurement window divided into 25 sub-windows, set + * Measurement window divided into 16 sub-windows, set * with ISP_HIST_XXX */ struct rkisp1_cif_isp_hist_stat {