diff mbox series

[v6,1/6] dt-bindings: spi: spi-rockchip: add description for rv1126

Message ID 20210607111837.31074-2-jon.lin@rock-chips.com (mailing list archive)
State New
Headers show
Series Support ROCKCHIP SPI new feature | expand

Commit Message

Jon Lin June 7, 2021, 11:18 a.m. UTC
The description below will be used for rv1126.dtsi or compatible one in
the future

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---

Changes in v6:
- Consider to compatibility, the "rockchip,rk3568-spi" is removed in
  Series-changes v5, so the commit massage should also remove the
  corresponding information

Changes in v5:
- Change to leave one compatible id rv1126, and rk3568 is compatible
  with rv1126

Changes in v4:
- Adjust the order patches
- Simply commit massage like redundancy "application" content

Changes in v3:
- Fix compile error which is find by Sascha in [v2,2/8]

 Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring June 10, 2021, 4:06 p.m. UTC | #1
On Mon, 07 Jun 2021 19:18:32 +0800, Jon Lin wrote:
> The description below will be used for rv1126.dtsi or compatible one in
> the future
> 
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
> 
> Changes in v6:
> - Consider to compatibility, the "rockchip,rk3568-spi" is removed in
>   Series-changes v5, so the commit massage should also remove the
>   corresponding information
> 
> Changes in v5:
> - Change to leave one compatible id rv1126, and rk3568 is compatible
>   with rv1126
> 
> Changes in v4:
> - Adjust the order patches
> - Simply commit massage like redundancy "application" content
> 
> Changes in v3:
> - Fix compile error which is find by Sascha in [v2,2/8]
> 
>  Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Johan Jonker June 10, 2021, 7:38 p.m. UTC | #2
Hi Rob,

Similar to the Rockchip SFC discussion this compatible does currently
not add any data or difference to the driver. Therefore a simple
fallback string will do for now. That in the past that was not strictly
enforced, so be it.
Could you have a look at it?

Kind regards,

Johan Jonker

https://lore.kernel.org/linux-rockchip/20210607063448.29589-1-jon.lin@rock-chips.com/T/#e202225dbe50829069becd2915267124f379bf2fe

               - rockchip,rk3368-spi
               - rockchip,rk3399-spi

               - rockchip,rv1126-spi

           - const: rockchip,rk3066-spi


On 6/10/21 6:06 PM, Rob Herring wrote:
> On Mon, 07 Jun 2021 19:18:32 +0800, Jon Lin wrote:
>> The description below will be used for rv1126.dtsi or compatible one in
>> the future
>>
>> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
>> ---
>>
>> Changes in v6:
>> - Consider to compatibility, the "rockchip,rk3568-spi" is removed in
>>   Series-changes v5, so the commit massage should also remove the
>>   corresponding information
>>
>> Changes in v5:
>> - Change to leave one compatible id rv1126, and rk3568 is compatible
>>   with rv1126
>>
>> Changes in v4:
>> - Adjust the order patches
>> - Simply commit massage like redundancy "application" content
>>
>> Changes in v3:
>> - Fix compile error which is find by Sascha in [v2,2/8]
>>
>>  Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
index 1e6cf29e6388..50d98c8f372c 100644
--- a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
@@ -34,6 +34,7 @@  properties:
               - rockchip,rk3368-spi
               - rockchip,rk3399-spi
           - const: rockchip,rk3066-spi
+      - const: rockchip,rv1126-spi
 
   reg:
     maxItems: 1