| Message ID | 20211010175457.438627-1-mike.rudenko@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: rockchip: rkisp1: use device name for debugfs subdir name | expand |
On Sun, Oct 10, 2021 at 08:54:57PM +0300, Mikhail Rudenko wrote: > While testing Rockchip RK3399 with both ISPs enabled, a dmesg error > was observed: > ``` > [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present! > ``` > > Fix it by using the device name for the debugfs subdirectory name > instead of the driver name, thus preventing name collision. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Thanks! > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index 7474150b94ed..560f928c3752 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) > { > struct rkisp1_debug *debug = &rkisp1->debug; > > - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL); > + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); > debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, > &debug->data_loss); > debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, > -- > 2.33.0 >
Hi Mikhail, Quoting Mikhail Rudenko (2021-10-10 18:54:57) > While testing Rockchip RK3399 with both ISPs enabled, a dmesg error > was observed: > ``` > [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present! > ``` > > Fix it by using the device name for the debugfs subdirectory name > instead of the driver name, thus preventing name collision. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index 7474150b94ed..560f928c3752 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) > { > struct rkisp1_debug *debug = &rkisp1->debug; > > - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL); > + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); I would wonder if they should be grouped under a subdir called rkisp1 ... but that would then still keep the same issue that whichever was second to probe would find that /rkisp1 was already present. I suspect debugfs would make it possible to check if the parent was already there and only create it if it exists, but anyway, it would then be harder to clean up too. So separate based on the nodes sounds perfectly reasonable to me. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, > &debug->data_loss); > debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, > -- > 2.33.0 >
On 2021-10-10 at 20:54 +03, Mikhail Rudenko <mike.rudenko@gmail.com> wrote: > While testing Rockchip RK3399 with both ISPs enabled, a dmesg error > was observed: > ``` > [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present! > ``` > > Fix it by using the device name for the debugfs subdirectory name > instead of the driver name, thus preventing name collision. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index 7474150b94ed..560f928c3752 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) > { > struct rkisp1_debug *debug = &rkisp1->debug; > > - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL); > + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); > debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, > &debug->data_loss); > debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, Gentle ping. Could this be merged please? -- Best regards, Mikhail Rudenko
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index 7474150b94ed..560f928c3752 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -426,7 +426,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) { struct rkisp1_debug *debug = &rkisp1->debug; - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL); + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL); debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, &debug->data_loss); debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
While testing Rockchip RK3399 with both ISPs enabled, a dmesg error was observed: ``` [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present! ``` Fix it by using the device name for the debugfs subdirectory name instead of the driver name, thus preventing name collision. Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)