diff mbox series

[4/4] arm64: dts: rockchip: Enable the GPU on Quartz64 Model A

Message ID 20211126151729.1026566-5-knaerzche@gmail.com (mailing list archive)
State New, archived
Headers show
Series add GPU for RK356x SoCs | expand

Commit Message

Alex Bee Nov. 26, 2021, 3:17 p.m. UTC
From: Ezequiel Garcia <ezequiel@collabora.com>

Enable the GPU core on the Pine64 Quartz64 Model A.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Piotr Oniszczuk Jan. 14, 2022, 4:25 p.m. UTC | #1
> Wiadomość napisana przez Alex Bee <knaerzche@gmail.com> w dniu 26.11.2021, o godz. 16:17:
> 
> From: Ezequiel Garcia <ezequiel@collabora.com>
> 
> Enable the GPU core on the Pine64 Quartz64 Model A.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> index 4d4b2a301b1a..625489c60622 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> @@ -205,6 +205,11 @@ &gmac1m0_clkinout
> 	status = "okay";
> };
> 
> +&gpu {
> +	mali-supply = <&vdd_gpu>;
> +	status = "okay";
> +};
> +
> &i2c0 {
> 	status = "okay";
> 
> -- 
> 

Alex, Ezequiel

I'm playing with 5.16 mainline on rk3566 based tvbox (x96-x6)

Box boots and I have working SD card, Eth, HDMI.

I applied this series as I want to get GPU working but I'm getting:

[    3.169144] panfrost fde60000.gpu: get clock failed -517
[    3.169646] panfrost fde60000.gpu: clk init failed -517
[    3.213653] panfrost fde60000.gpu: get clock failed -517
[    3.214156] panfrost fde60000.gpu: clk init failed -517
[    3.230505] panfrost fde60000.gpu: get clock failed -517
[    3.231006] panfrost fde60000.gpu: clk init failed -517
[    3.258072] panfrost fde60000.gpu: get clock failed -517
[    3.258575] panfrost fde60000.gpu: clk init failed -517

Maybe you have some hints here?
Robin Murphy Jan. 14, 2022, 4:42 p.m. UTC | #2
On 2022-01-14 16:25, Piotr Oniszczuk wrote:
> 
> 
>> Wiadomość napisana przez Alex Bee <knaerzche@gmail.com> w dniu 26.11.2021, o godz. 16:17:
>>
>> From: Ezequiel Garcia <ezequiel@collabora.com>
>>
>> Enable the GPU core on the Pine64 Quartz64 Model A.
>>
>> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
>> index 4d4b2a301b1a..625489c60622 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
>> @@ -205,6 +205,11 @@ &gmac1m0_clkinout
>> 	status = "okay";
>> };
>>
>> +&gpu {
>> +	mali-supply = <&vdd_gpu>;
>> +	status = "okay";
>> +};
>> +
>> &i2c0 {
>> 	status = "okay";
>>
>> -- 
>>
> 
> Alex, Ezequiel
> 
> I'm playing with 5.16 mainline on rk3566 based tvbox (x96-x6)
> 
> Box boots and I have working SD card, Eth, HDMI.
> 
> I applied this series as I want to get GPU working but I'm getting:
> 
> [    3.169144] panfrost fde60000.gpu: get clock failed -517
> [    3.169646] panfrost fde60000.gpu: clk init failed -517
> [    3.213653] panfrost fde60000.gpu: get clock failed -517
> [    3.214156] panfrost fde60000.gpu: clk init failed -517
> [    3.230505] panfrost fde60000.gpu: get clock failed -517
> [    3.231006] panfrost fde60000.gpu: clk init failed -517
> [    3.258072] panfrost fde60000.gpu: get clock failed -517
> [    3.258575] panfrost fde60000.gpu: clk init failed -517
> 
> Maybe you have some hints here?

517 is EPROBE_DEFER, which implies it's waiting for the relevant clock 
provider to show up. I see from patch #2 that SCMI is involved, so I'd 
check that that's working and you have CONFIG_COMMON_CLOCK_SCMI enabled.

Robin.
Piotr Oniszczuk Jan. 14, 2022, 5:56 p.m. UTC | #3
> Wiadomość napisana przez Robin Murphy <robin.murphy@arm.com> w dniu 14.01.2022, o godz. 17:42:
> 
>> 
> 
> 517 is EPROBE_DEFER, which implies it's waiting for the relevant clock provider to show up. I see from patch #2 that SCMI is involved, so I'd check that that's working and you have CONFIG_COMMON_CLOCK_SCMI enabled.
> 
> Robin.

Robin,

Many thx!
Indeed issue was with SCMi CLK.
Now i see:

[    3.092350] panfrost fde60000.gpu: clock rate = 594000000
[    3.092906] panfrost fde60000.gpu: bus_clock rate = 500000000
[    3.138340] panfrost fde60000.gpu: clock rate = 594000000
[    3.138904] panfrost fde60000.gpu: bus_clock rate = 500000000
[    3.171244] panfrost fde60000.gpu: clock rate = 594000000
[    3.171888] panfrost fde60000.gpu: bus_clock rate = 500000000

good.

(unfortunately mesa 21.3.4 still goes with llvmpipe but this seems to be other issue i need to investigate)

thx again!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
index 4d4b2a301b1a..625489c60622 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
@@ -205,6 +205,11 @@  &gmac1m0_clkinout
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &i2c0 {
 	status = "okay";