| Message ID | 20220107051335.3812535-5-pgwipeout@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add pine64 touch panel support to rockpro64 | expand |
Hi Peter, Am Freitag, 7. Januar 2022, 06:13:35 CET schrieb Peter Geis: > Enable the touch screen, backlight, and dsi nodes for the Pine64 touch panel > attached to the rockpro64. can you please also include me in the other patches of the series? I.e. they introduce a new property for the display, so it's nice to know when they get applied. While I do agree with patch 3/4, I'm hesistant about this one. The display/touchscreen will probably not be connected on every rockpro64 so what happens if it doesn't? I.e are there alternative uses for the affected pins, that may get fried when this is always enabled? So part of me would think that an dt-overlay enabling this might be the nicer way to go? Heiko > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > index 158befb9a48c..f6c36fcd6db3 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > @@ -26,7 +26,7 @@ backlight: backlight { > pwms = <&pwm0 0 1000000 0>; > brightness-levels = <0 4 8 16 32 64 128 255>; > default-brightness-level = <5>; > - status = "disabled"; > + status = "okay"; > }; > > clkin_gmac: external-gmac-clock { > @@ -594,7 +594,7 @@ touch: touchscreen@5d { > interrupts = <RK_PD5 IRQ_TYPE_EDGE_FALLING>; > irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; > reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; > - status = "disabled"; > + status = "okay"; > }; > }; > > @@ -633,7 +633,7 @@ &io_domains { > > /* enable for pine64 panel display support */ > &mipi_dsi { > - status = "disabled"; > + status = "okay"; > clock-master; > > ports { >
On Sun, Jan 23, 2022 at 10:30 AM Heiko Stuebner <heiko@sntech.de> wrote: > > Hi Peter, > > Am Freitag, 7. Januar 2022, 06:13:35 CET schrieb Peter Geis: > > Enable the touch screen, backlight, and dsi nodes for the Pine64 touch panel > > attached to the rockpro64. > > can you please also include me in the other patches of the series? > I.e. they introduce a new property for the display, so it's nice to know > when they get applied. Apologies, I use get-maintainers.pl automatically and it seems to need some help with tagging you in some Rockchip elements. I'll be sure to always manually include you and the rockchip mailing list on all patches in future series of this sort. > > While I do agree with patch 3/4, I'm hesistant about this one. > The display/touchscreen will probably not be connected on every rockpro64 > so what happens if it doesn't? This was supposed to be tagged as Do-Not-Merge, but it seems I failed to do so on the actual patch. It's here for purely completeness and testing purposes. > > I.e are there alternative uses for the affected pins, that may get fried > when this is always enabled? > > So part of me would think that an dt-overlay enabling this might be the > nicer way to go? Absolutely. > > > Heiko Thanks, Peter > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > --- > > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > > index 158befb9a48c..f6c36fcd6db3 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi > > @@ -26,7 +26,7 @@ backlight: backlight { > > pwms = <&pwm0 0 1000000 0>; > > brightness-levels = <0 4 8 16 32 64 128 255>; > > default-brightness-level = <5>; > > - status = "disabled"; > > + status = "okay"; > > }; > > > > clkin_gmac: external-gmac-clock { > > @@ -594,7 +594,7 @@ touch: touchscreen@5d { > > interrupts = <RK_PD5 IRQ_TYPE_EDGE_FALLING>; > > irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; > > reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; > > - status = "disabled"; > > + status = "okay"; > > }; > > }; > > > > @@ -633,7 +633,7 @@ &io_domains { > > > > /* enable for pine64 panel display support */ > > &mipi_dsi { > > - status = "disabled"; > > + status = "okay"; > > clock-master; > > > > ports { > > > > > >
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi index 158befb9a48c..f6c36fcd6db3 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi @@ -26,7 +26,7 @@ backlight: backlight { pwms = <&pwm0 0 1000000 0>; brightness-levels = <0 4 8 16 32 64 128 255>; default-brightness-level = <5>; - status = "disabled"; + status = "okay"; }; clkin_gmac: external-gmac-clock { @@ -594,7 +594,7 @@ touch: touchscreen@5d { interrupts = <RK_PD5 IRQ_TYPE_EDGE_FALLING>; irq-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio4 RK_PD6 GPIO_ACTIVE_HIGH>; - status = "disabled"; + status = "okay"; }; }; @@ -633,7 +633,7 @@ &io_domains { /* enable for pine64 panel display support */ &mipi_dsi { - status = "disabled"; + status = "okay"; clock-master; ports {
Enable the touch screen, backlight, and dsi nodes for the Pine64 touch panel attached to the rockpro64. Signed-off-by: Peter Geis <pgwipeout@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)