| Message ID | 20220421144304.586396-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static | expand |
On Thu, 21 Apr 2022 10:43:04 -0400, Tom Rix wrote: > Smatch reports this issue > cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static? > > rk3399_cdn_dp is only used in cdn-dp-core.c so change > its storge-class specifier to static. Applied, thanks! [1/1] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static commit: 7494b1ed1df414e43dc8429f0c016b2054b1b5da Best regards,
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index d3e6c93739bf..ce67c9daa2b1 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -48,7 +48,7 @@ struct cdn_dp_data { u8 max_phy; }; -struct cdn_dp_data rk3399_cdn_dp = { +static struct cdn_dp_data rk3399_cdn_dp = { .max_phy = 2, };
Smatch reports this issue cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static? rk3399_cdn_dp is only used in cdn-dp-core.c so change its storge-class specifier to static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)