| Message ID | 20220421234240.1694-22-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: rkisp1: Misc bug fixes and cleanups | expand |
Laurent Pinchart wrote: > Fix a small indentation issue to increase code readability, and drop > unneeded parentheses. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > index c7ad1986e67b..97d569968285 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c > @@ -486,9 +486,9 @@ static int rkisp1_probe(struct platform_device *pdev) > return PTR_ERR(rkisp1->base_addr); > > for (i = 0; i < match_data->isr_size; i++) { > - irq = (match_data->isrs[i].name) ? > - platform_get_irq_byname(pdev, match_data->isrs[i].name) : > - platform_get_irq(pdev, i); > + irq = match_data->isrs[i].name Shouldn't the question mark be in the previous line?, not complaining, just asking :) > + ? platform_get_irq_byname(pdev, match_data->isrs[i].name) > + : platform_get_irq(pdev, i); > if (irq < 0) > return irq; > > -- > Regards, > > Laurent Pinchart > >
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index c7ad1986e67b..97d569968285 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -486,9 +486,9 @@ static int rkisp1_probe(struct platform_device *pdev) return PTR_ERR(rkisp1->base_addr); for (i = 0; i < match_data->isr_size; i++) { - irq = (match_data->isrs[i].name) ? - platform_get_irq_byname(pdev, match_data->isrs[i].name) : - platform_get_irq(pdev, i); + irq = match_data->isrs[i].name + ? platform_get_irq_byname(pdev, match_data->isrs[i].name) + : platform_get_irq(pdev, i); if (irq < 0) return irq;
Fix a small indentation issue to increase code readability, and drop unneeded parentheses. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)