diff mbox series

[3/5] mmc: dw_mmc: rockchip: Obviously always return success in remove callback

Message ID 20220610211257.102071-3-u.kleine-koenig@pengutronix.de (mailing list archive)
State New
Headers show
Series None | expand

Commit Message

Uwe Kleine-König June 10, 2022, 9:12 p.m. UTC
dw_mci_pltfm_remove() returns 0 unconditionally and returning an error
in a platform remove callback isn't very sensible. (The only effect of
the latter is that the device core emits a generic warning and then
removes the device anyhow.)

So return 0 unconditionally to make it obvious there is no error
forwarded to the upper layers.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/mmc/host/dw_mmc-rockchip.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index f825487aa739..2a99f15f527f 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -377,7 +377,9 @@  static int dw_mci_rockchip_remove(struct platform_device *pdev)
-	return dw_mci_pltfm_remove(pdev);
+	dw_mci_pltfm_remove(pdev);
+	return 0;
 static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = {