diff mbox series

[2/3] dt-bindings: arm: rockchip: Add Anbernic RG353 and RG503

Message ID 20220817204954.28135-3-macroalpha82@gmail.com (mailing list archive)
State Superseded
Headers show
Series Add Anbernic RG353 and RG503 | expand

Commit Message

Chris Morgan Aug. 17, 2022, 8:49 p.m. UTC 
From: Chris Morgan <macromorgan@hotmail.com>

Add entry for the Anbernic RG353 and RG503 handheld devices.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Krzysztof Kozlowski Aug. 18, 2022, 8:11 a.m. UTC | #1 
On 17/08/2022 23:49, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add entry for the Anbernic RG353 and RG503 handheld devices.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Maya Matuszczyk Aug. 18, 2022, 8:26 a.m. UTC | #2 
Hey,

śr., 17 sie 2022 o 22:50 Chris Morgan <macroalpha82@gmail.com> napisał(a):
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add entry for the Anbernic RG353 and RG503 handheld devices.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 7811ba64149c..9026963694f0 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -30,6 +30,16 @@ properties:
>            - const: amarula,vyasa-rk3288
>            - const: rockchip,rk3288
>
> +      - description: Anbernic RG353
> +        items:
> +          - const: anbernic,rg353
> +          - const: rockchip,rk3566
The device is named RG353P, not RG353.
Otherwise patch looks good to me.

Best Regards,
Maya Matuszczyk
Chris Morgan Aug. 18, 2022, 4:29 p.m. UTC | #3 
On Thu, Aug 18, 2022 at 10:26:58AM +0200, Maya Matuszczyk wrote:
> Hey,
> 
> śr., 17 sie 2022 o 22:50 Chris Morgan <macroalpha82@gmail.com> napisał(a):
> >
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Add entry for the Anbernic RG353 and RG503 handheld devices.
> >
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index 7811ba64149c..9026963694f0 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -30,6 +30,16 @@ properties:
> >            - const: amarula,vyasa-rk3288
> >            - const: rockchip,rk3288
> >
> > +      - description: Anbernic RG353
> > +        items:
> > +          - const: anbernic,rg353
> > +          - const: rockchip,rk3566
> The device is named RG353P, not RG353.
> Otherwise patch looks good to me.

Acknowledged, will update in next patch series.

> 
> Best Regards,
> Maya Matuszczyk
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 7811ba64149c..9026963694f0 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -30,6 +30,16 @@  properties:
           - const: amarula,vyasa-rk3288
           - const: rockchip,rk3288
 
+      - description: Anbernic RG353
+        items:
+          - const: anbernic,rg353
+          - const: rockchip,rk3566
+
+      - description: Anbernic RG503
+        items:
+          - const: anbernic,rg503
+          - const: rockchip,rk3566
+
       - description: Asus Tinker board
         items:
           - const: asus,rk3288-tinker