| Message ID | 20220822164453.1.I75c57b48b0873766ec993bdfb7bc1e63da5a1637@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob | expand |
Hi, On Mon, Aug 22, 2022 at 4:45 PM Brian Norris <briannorris@chromium.org> wrote: > > The Gru-Bob board does not have a pull-up resistor on its > WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel > specified the pin configuration correctly as a pull-up, but this didn't > get ported correctly to upstream. > > This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent > wakeup behavior. > > Note that bt_host_wake_l has a similar dynamic, but apparently the > upstream choice was to redundantly configure both internal and external > pull-up on Kevin (see the "Kevin has an external pull up" comment in > rk3399-gru.dtsi). This doesn't cause any functional problem, although > it's perhaps wasteful. > > Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob") > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > > arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 5 +++++ > arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 + > 2 files changed, 6 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon, 22 Aug 2022 16:45:04 -0700, Brian Norris wrote: > The Gru-Bob board does not have a pull-up resistor on its > WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel > specified the pin configuration correctly as a pull-up, but this didn't > get ported correctly to upstream. > > This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent > wakeup behavior. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob commit: e5467359a725de90b6b8d0dd865500f6373828ca Best regards,
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts index 31ebb4e5fd33..0f9cc042d9bf 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts @@ -88,3 +88,8 @@ h1_int_od_l: h1-int-od-l { }; }; }; + +&wlan_host_wake_l { + /* Kevin has an external pull up, but Bob does not. */ + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>; +}; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi index cd074641884b..45796b9fd94f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi @@ -578,6 +578,7 @@ wifi_perst_l: wifi-perst-l { }; wlan_host_wake_l: wlan-host-wake-l { + /* Kevin has an external pull up, but Bob does not */ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; }; };
The Gru-Bob board does not have a pull-up resistor on its WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel specified the pin configuration correctly as a pull-up, but this didn't get ported correctly to upstream. This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent wakeup behavior. Note that bt_host_wake_l has a similar dynamic, but apparently the upstream choice was to redundantly configure both internal and external pull-up on Kevin (see the "Kevin has an external pull up" comment in rk3399-gru.dtsi). This doesn't cause any functional problem, although it's perhaps wasteful. Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob") Signed-off-by: Brian Norris <briannorris@chromium.org> --- arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 5 +++++ arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi | 1 + 2 files changed, 6 insertions(+)