| Message ID | 20220920103108.23074-14-jay.xu@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rockchip pinctrl/GPIO support ACPI | expand |
On Tue, Sep 20, 2022 at 12:31 PM Jianqun Xu <jay.xu@rock-chips.com> wrote: > > Match to the probe, do disable and put the clocks when module to remove. > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > drivers/gpio/gpio-rockchip.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index 511e93a6a429..1a800f972594 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -757,7 +757,10 @@ static int rockchip_gpio_remove(struct platform_device *pdev) > { > struct rockchip_pin_bank *bank = platform_get_drvdata(pdev); > > + clk_put(bank->clk); > + clk_put(bank->db_clk); > clk_disable_unprepare(bank->clk); > + clk_disable_unprepare(bank->db_clk); > gpiochip_remove(&bank->gpio_chip); > > return 0; > -- > 2.25.1 > You're putting the clock before disabling it? That doesn't look right. Bart
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 511e93a6a429..1a800f972594 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -757,7 +757,10 @@ static int rockchip_gpio_remove(struct platform_device *pdev) { struct rockchip_pin_bank *bank = platform_get_drvdata(pdev); + clk_put(bank->clk); + clk_put(bank->db_clk); clk_disable_unprepare(bank->clk); + clk_disable_unprepare(bank->db_clk); gpiochip_remove(&bank->gpio_chip); return 0;
Match to the probe, do disable and put the clocks when module to remove. Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/gpio/gpio-rockchip.c | 3 +++ 1 file changed, 3 insertions(+)