diff mbox series

arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4

Message ID 20220928091129.20597-1-jensenhuang@friendlyarm.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4 | expand

Commit Message

Jensen Huang Sept. 28, 2022, 9:11 a.m. UTC
Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.

Tested on NanoPC-T4.

Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts")
Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stuebner Oct. 17, 2022, 12:34 p.m. UTC | #1
On Wed, 28 Sep 2022 17:11:29 +0800, Jensen Huang wrote:
> Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
> by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.
> 
> Tested on NanoPC-T4.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4
      commit: 463be3cb357dab7d7e4d8dcc7c15c642e10c5bef

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index 278123b4f911..b6e082f1f6d9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -167,6 +167,7 @@  &cpu_l3 {
 };
 
 &emmc_phy {
+	rockchip,enable-strobe-pulldown;
 	status = "okay";
 };