| Message ID | 20221021172012.87954-1-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions | expand |
Am Freitag, 21. Oktober 2022, 19:20:12 CEST schrieb Sebastian Reichel: > Apparently RK3588 pinctrl has 13 different device functions, but dt-validate > only checks for pin configuration being referenced so I did not notice. > > Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Acked-by: Heiko Stuebner <heiko@sntech.de>
On 21/10/2022 13:20, Sebastian Reichel wrote: > Apparently RK3588 pinctrl has 13 different device functions, but dt-validate > only checks for pin configuration being referenced so I did not notice. I think the "but ..." part can be skipped, as it is not really relevant to the issue being fixed here. > > Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Oct 21, 2022 at 7:20 PM Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > Apparently RK3588 pinctrl has 13 different device functions, but dt-validate > only checks for pin configuration being referenced so I did not notice. > > Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Patch applied! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml index b486f41df65f..d6539723f354 100644 --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml @@ -132,7 +132,7 @@ additionalProperties: description: Pin bank index. - minimum: 0 - maximum: 10 + maximum: 13 description: Mux 0 means GPIO and mux 1 to N means the specific device function.
Apparently RK3588 pinctrl has 13 different device functions, but dt-validate only checks for pin configuration being referenced so I did not notice. Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)