From patchwork Mon Dec 5 13:40:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 13064496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71A62C4321E for ; Mon, 5 Dec 2022 13:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J90CstzjuN4G2XGLdrdWTmcQjHTokP7GzgjowB7uAZM=; b=y6A+6/Oq7kcLbK 1ly9Dq2Rg8IAosRwc5DcU31F+Vi5iTQnBn5QjHQbdvYvqm6DynBlagLmtLXKfoWW0NCe5HWBMlt+f kuJHHgN8Ls9ay4FKf71p1xKs0iuOIklLBoDNSYuiXvRfcwciZOr694k8Zxm7dAQnKdGYTvKWMn0ED t07YW94o6P2w/ywU3dVja+HWWipIjLpWFzO1HcXSPBqHW/h2QU7l4KsfkdyHgalk5HuOeynDWMwW4 lJvvRvYhWvw4JcuOdcjmPWIAVjfe00hm4Hpsx8S4ToVuMi+vqvNZlGHdjiHsdTN0YGHHUL/EnY3ED L3nOMjnOmLjf/r1EII7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2Bj3-003ZyS-EV; Mon, 05 Dec 2022 13:41:41 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2Bip-003ZXS-Ki; Mon, 05 Dec 2022 13:41:29 +0000 Received: (Authenticated sender: foss@0leil.net) by mail.gandi.net (Postfix) with ESMTPSA id 79BC4FF811; Mon, 5 Dec 2022 13:41:14 +0000 (UTC) From: Quentin Schulz To: Samuel Holland , Bastien Nocera , =?utf-8?q?Guido_G=C3=BCnther?= , Sascha Hauer , Pengutronix Kernel Team , Angus Ainslie , Ondrej Jirman , Icenowy Zheng , Andy Gross , Aleksei Mamlin , Fabio Estevam , David Jander , Frieder Schrempf , Bjorn Andersson , Konrad Dybcio , Peter Geis , Heiko Stuebner , Shawn Guo , Jernej Skrabec , Lukasz Majewski , AngeloGioacchino Del Regno , Chen-Yu Tsai , Michael Riesch , Rob Herring , NXP Linux Team , Dmitry Torokhov , Hans de Goede , Jagan Teki , Krzysztof Kozlowski Cc: Quentin Schulz , linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH v3 2/9] Input: goodix - make gpiod_get honor GPIOD_ASIS Date: Mon, 5 Dec 2022 14:40:31 +0100 Message-Id: <20221103-upstream-goodix-reset-v3-2-0975809eb183@theobroma-systems.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221103-upstream-goodix-reset-v3-0-0975809eb183@theobroma-systems.com> References: <20221103-upstream-goodix-reset-v3-0-0975809eb183@theobroma-systems.com> MIME-Version: 1.0 X-Mailer: b4 0.10.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_054127_961574_B1964ACA X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Quentin Schulz For some reason the ACPI GPIO lookup code (acpi_find_gpio followed by acpi_gpio_update_gpiod_flags) will override the gpiod_flags passed to gpiod_get() if it can determine a set of flags from the ACPI GpioIo entry. For output pins like the reset pin, this requires a pull bias to be set, which often is not the case, so then the GPIOD_ASIS which we pass in is used. But if a pull bias is specified in the ACPI GpioIo entry for the reset pin then that gets translated to GPIOD_OUT_LOW or GPIOD_OUT_HIGH meaning we cannot guarantee the same behavior on all boards. So this may cause unintended side-effects, c.f. commit a2fd46cd3dbb ("Input: goodix - try not to touch the reset-pin on x86/ACPI devices") for some background. This is something which we can fix though, we can force the ACPI GPIO code to honor the GPIOD_ASIS we pass in by passing ACPI_GPIO_QUIRK_NO_IO_RESTRICTION to the ACPI gpio mapping. Suggested-by: Hans de Goede Signed-off-by: Quentin Schulz --- drivers/input/touchscreen/goodix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index d73d4272a8ea5..1639f2f8a31e3 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -803,6 +803,7 @@ static int goodix_reset(struct goodix_ts_data *ts) .name = _name, \ .data = _params, \ .size = _size, \ + .quirks = ACPI_GPIO_QUIRK_NO_IO_RESTRICTION, \ } static const struct acpi_gpio_params first_gpio = { 0, 0, false };