| Message ID | 20221226063625.1913-3-anand@edgeble.ai (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PATCHv2,linux-next,1/4] dt-bindings: net: rockchip-dwmac: fix rv1126 compatible warning | expand |
On Mon, 26 Dec 2022 at 12:07, Anand Moon <anand@edgeble.ai> wrote: > > Rockchip RV1126 has GMAC 10/100/1000M ethernet controller > add GMAC node for RV1126 SoC. > > Signed-off-by: Anand Moon <anand@edgeble.ai> > --- > drop SoB of Jagan Teki > --- > arch/arm/boot/dts/rv1126.dtsi | 63 +++++++++++++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/arch/arm/boot/dts/rv1126.dtsi b/arch/arm/boot/dts/rv1126.dtsi > index 1cb43147e90b..bae318c1d839 100644 > --- a/arch/arm/boot/dts/rv1126.dtsi > +++ b/arch/arm/boot/dts/rv1126.dtsi > @@ -90,6 +90,69 @@ xin24m: oscillator { > #clock-cells = <0>; > }; > > + gmac_clkin_m0: external-gmac-clockm0 { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "clk_gmac_rgmii_clkin_m0"; > + #clock-cells = <0>; > + }; > + > + gmac_clkini_m1: external-gmac-clockm1 { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "clk_gmac_rgmii_clkin_m1"; > + #clock-cells = <0>; > + }; These seems not needed,
Hi Jagan, Thanks for the review comments. On Mon, 26 Dec 2022 at 15:20, Jagan Teki <jagan@edgeble.ai> wrote: > > On Mon, 26 Dec 2022 at 12:07, Anand Moon <anand@edgeble.ai> wrote: > > > > Rockchip RV1126 has GMAC 10/100/1000M ethernet controller > > add GMAC node for RV1126 SoC. > > > > Signed-off-by: Anand Moon <anand@edgeble.ai> > > --- > > drop SoB of Jagan Teki > > --- > > arch/arm/boot/dts/rv1126.dtsi | 63 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rv1126.dtsi b/arch/arm/boot/dts/rv1126.dtsi > > index 1cb43147e90b..bae318c1d839 100644 > > --- a/arch/arm/boot/dts/rv1126.dtsi > > +++ b/arch/arm/boot/dts/rv1126.dtsi > > @@ -90,6 +90,69 @@ xin24m: oscillator { > > #clock-cells = <0>; > > }; > > > > + gmac_clkin_m0: external-gmac-clockm0 { > > + compatible = "fixed-clock"; > > + clock-frequency = <125000000>; > > + clock-output-names = "clk_gmac_rgmii_clkin_m0"; > > + #clock-cells = <0>; > > + }; > > + > > + gmac_clkini_m1: external-gmac-clockm1 { > > + compatible = "fixed-clock"; > > + clock-frequency = <125000000>; > > + clock-output-names = "clk_gmac_rgmii_clkin_m1"; > > + #clock-cells = <0>; > > + }; > > These seems not needed, Ok, I will drop this in next version. Thanks -Anand
diff --git a/arch/arm/boot/dts/rv1126.dtsi b/arch/arm/boot/dts/rv1126.dtsi index 1cb43147e90b..bae318c1d839 100644 --- a/arch/arm/boot/dts/rv1126.dtsi +++ b/arch/arm/boot/dts/rv1126.dtsi @@ -90,6 +90,69 @@ xin24m: oscillator { #clock-cells = <0>; }; + gmac_clkin_m0: external-gmac-clockm0 { + compatible = "fixed-clock"; + clock-frequency = <125000000>; + clock-output-names = "clk_gmac_rgmii_clkin_m0"; + #clock-cells = <0>; + }; + + gmac_clkini_m1: external-gmac-clockm1 { + compatible = "fixed-clock"; + clock-frequency = <125000000>; + clock-output-names = "clk_gmac_rgmii_clkin_m1"; + #clock-cells = <0>; + }; + + gmac: ethernet@ffc40000 { + compatible = "rockchip,rv1126-gmac", "snps,dwmac-4.20a"; + reg = <0xffc40000 0x4000>; + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq", "eth_wake_irq"; + rockchip,grf = <&grf>; + clocks = <&cru CLK_GMAC_SRC>, <&cru CLK_GMAC_TX_RX>, + <&cru CLK_GMAC_TX_RX>, <&cru CLK_GMAC_REF>, + <&cru ACLK_GMAC>, <&cru PCLK_GMAC>, + <&cru CLK_GMAC_TX_RX>, <&cru CLK_GMAC_PTPREF>; + clock-names = "stmmaceth", "mac_clk_rx", + "mac_clk_tx", "clk_mac_ref", + "aclk_mac", "pclk_mac", + "clk_mac_speed", "ptp_ref"; + resets = <&cru SRST_GMAC_A>; + reset-names = "stmmaceth"; + + snps,mixed-burst; + snps,tso; + + snps,axi-config = <&stmmac_axi_setup>; + snps,mtl-rx-config = <&mtl_rx_setup>; + snps,mtl-tx-config = <&mtl_tx_setup>; + status = "disabled"; + + mdio: mdio { + compatible = "snps,dwmac-mdio"; + #address-cells = <0x1>; + #size-cells = <0x0>; + }; + + stmmac_axi_setup: stmmac-axi-config { + snps,wr_osr_lmt = <4>; + snps,rd_osr_lmt = <8>; + snps,blen = <0 0 0 0 16 8 4>; + }; + + mtl_rx_setup: rx-queues-config { + snps,rx-queues-to-use = <1>; + queue0 {}; + }; + + mtl_tx_setup: tx-queues-config { + snps,tx-queues-to-use = <1>; + queue0 {}; + }; + }; + grf: syscon@fe000000 { compatible = "rockchip,rv1126-grf", "syscon", "simple-mfd"; reg = <0xfe000000 0x20000>;
Rockchip RV1126 has GMAC 10/100/1000M ethernet controller add GMAC node for RV1126 SoC. Signed-off-by: Anand Moon <anand@edgeble.ai> --- drop SoB of Jagan Teki --- arch/arm/boot/dts/rv1126.dtsi | 63 +++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+)