| Message ID | 20221228140708.26431-1-tom@tom-fitzhenry.me.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mfd: rk808: re-add rk808-clkout to RK818 | expand |
Hello Tom, On 12/28/22 15:07, Tom Fitzhenry wrote: > Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which > dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. > > This line was removed in commit 3633daacea2e > ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. > Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ? > Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk> > --- The patch looks good to me. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On 28/12/2022 15:07, Tom Fitzhenry wrote: > Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which > dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. > > This line was removed in commit 3633daacea2e > ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. > > Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk> > --- > drivers/mfd/rk808.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index f44fc3f080a8..0f22ef61e817 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = { > }; > > static const struct mfd_cell rk818s[] = { > + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, }, > { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, }, > { > .name = "rk808-rtc", > > base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5 Sorry, my bad... Acked-by: Neil Armstrong <neil.armstrong@linaro.org> Thanks, Neil
On 2/1/23 21:06, Neil Armstrong wrote: > On 28/12/2022 15:07, Tom Fitzhenry wrote: >> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which >> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. >> >> This line was removed in commit 3633daacea2e >> ("mfd: rk808: Permit having multiple PMIC instances"), but only from >> RK818. >> >> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk> >> --- >> drivers/mfd/rk808.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c >> index f44fc3f080a8..0f22ef61e817 100644 >> --- a/drivers/mfd/rk808.c >> +++ b/drivers/mfd/rk808.c >> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = { >> }; >> static const struct mfd_cell rk818s[] = { >> + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, }, >> { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, }, >> { >> .name = "rk808-rtc", >> >> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5 > > Sorry, my bad... No worries! > Acked-by: Neil Armstrong <neil.armstrong@linaro.org> Thanks, I have added this to the v2 patch.
On 30/12/22 05:27, Javier Martinez Canillas wrote: > On 12/28/22 15:07, Tom Fitzhenry wrote: >> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which >> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. >> >> This line was removed in commit 3633daacea2e >> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. >> > > Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ? SGTM. I have added this to the v2 patch. > The patch looks good to me. > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thanks, I have added this to the v2 patch.
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index f44fc3f080a8..0f22ef61e817 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = { }; static const struct mfd_cell rk818s[] = { + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, }, { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, }, { .name = "rk808-rtc",
Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. This line was removed in commit 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk> --- drivers/mfd/rk808.c | 1 + 1 file changed, 1 insertion(+) base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5