| Message ID | 20230315173657.28692-2-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: Add support for RTL8821CS | expand |
On 15/03/2023 18:36, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > driver. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../bindings/net/realtek-bluetooth.yaml | 24 ++++++++++++------- > 1 file changed, 15 insertions(+), 9 deletions(-) > This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On Thu, Mar 16, 2023 at 08:55:13AM +0100, Krzysztof Kozlowski wrote: > On 15/03/2023 18:36, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > > driver. > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > .../bindings/net/realtek-bluetooth.yaml | 24 ++++++++++++------- > > 1 file changed, 15 insertions(+), 9 deletions(-) > > > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. I removed it on purpose and noted it in the cover letter because I changed the bindings. I apologize if that's not correct. I changed the fallback from "realtek,rtl8822cs-bt" to "realtek,rtl8723bs-bt". From the driver perspective that causes it to disable runtime power management, but otherwise it's identical to V4. Thank you. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions. However, there's no need to repost patches *only* to add the > tags. The upstream maintainer will do that for acks received on the > version they apply. > > https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 > > If a tag was not added on purpose, please state why and what changed. > > > Best regards, > Krzysztof >
On 15/03/2023 18:36, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > driver. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../bindings/net/realtek-bluetooth.yaml | 24 ++++++++++++------- > 1 file changed, 15 insertions(+), 9 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml index 143b5667abad..506ea9b17668 100644 --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml @@ -4,24 +4,30 @@ $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth maintainers: - Vasily Khoruzhick <anarsoul@gmail.com> - Alistair Francis <alistair@alistair23.me> description: - RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over - SDIO, while BT is connected over serial. It speaks H5 protocol with few - extra commands to upload firmware and change module speed. + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part + is connected over SDIO, while BT is connected over serial. It speaks + H5 protocol with few extra commands to upload firmware and change + module speed. properties: compatible: - enum: - - realtek,rtl8723bs-bt - - realtek,rtl8723cs-bt - - realtek,rtl8723ds-bt - - realtek,rtl8822cs-bt + oneOf: + - enum: + - realtek,rtl8723bs-bt + - realtek,rtl8723cs-bt + - realtek,rtl8723ds-bt + - realtek,rtl8822cs-bt + - items: + - enum: + - realtek,rtl8821cs-bt + - const: realtek,rtl8723bs-bt device-wake-gpios: maxItems: 1