| Message ID | 20230617135315.25441-2-f.kardame@manjaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for Firefly Station P2 aka rk3568-roc-pc | expand |
Hey Furkan, On Sat, Jun 17, 2023 at 04:53:14PM +0300, Furkan Kardame wrote: > Station P2 is a single board computer by firefly based > on rk3568 soc > > Signed-off-by: Furkan Kardame <f.kardame@manjaro.org> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index ec141c937..fa21640bc 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -185,6 +185,11 @@ properties: > - const: firefly,rk3566-roc-pc > - const: rockchip,rk3566 > > + - description: Firefly Station P2 > + items: > + - const: firefly,rk3568-roc-pc > + - const: rockchip,rk3568 yaml files are indented with spaces, not tabs. Cheers, Conor. > + > - description: FriendlyElec NanoPi R2 series boards > items: > - enum: > -- > 2.40.1 >
On 17/06/2023 22:40, Conor Dooley wrote: > Hey Furkan, > > On Sat, Jun 17, 2023 at 04:53:14PM +0300, Furkan Kardame wrote: >> Station P2 is a single board computer by firefly based >> on rk3568 soc >> >> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org> >> --- >> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >> index ec141c937..fa21640bc 100644 >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >> @@ -185,6 +185,11 @@ properties: >> - const: firefly,rk3566-roc-pc >> - const: rockchip,rk3566 >> >> + - description: Firefly Station P2 >> + items: >> + - const: firefly,rk3568-roc-pc >> + - const: rockchip,rk3568 > > yaml files are indented with spaces, not tabs. > Which is pointed out by testing, so this was not tested :( Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
On Sat, 17 Jun 2023 16:53:14 +0300, Furkan Kardame wrote: > Station P2 is a single board computer by firefly based > on rk3568 soc > > Signed-off-by: Furkan Kardame <f.kardame@manjaro.org> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/rockchip.yaml:189:1: [error] syntax error: found character '\t' that cannot start any token (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/rockchip.example.dts' Documentation/devicetree/bindings/arm/rockchip.yaml:189:1: found a tab character that violates indentation make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/arm/rockchip.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/arm/rockchip.yaml:189:1: found a tab character that violates indentation /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/rockchip.yaml: ignoring, error parsing file make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230617135315.25441-2-f.kardame@manjaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index ec141c937..fa21640bc 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -185,6 +185,11 @@ properties: - const: firefly,rk3566-roc-pc - const: rockchip,rk3566 + - description: Firefly Station P2 + items: + - const: firefly,rk3568-roc-pc + - const: rockchip,rk3568 + - description: FriendlyElec NanoPi R2 series boards items: - enum:
Station P2 is a single board computer by firefly based on rk3568 soc Signed-off-by: Furkan Kardame <f.kardame@manjaro.org> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)