| Message ID | 20231202071212.1606800-1-CFSworks@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls | expand |
On Fri, 1 Dec 2023 23:12:12 -0800, Sam Edwards wrote: > The pinctrls for the hym8563 interrupt line and fan-tach input > were both mistakenly defined as `pcfg_pull_none`. As these are > active-low signals (level-triggered, in the hym8563 case) which > may not be driven at times, these should really be pull-up. The > lack of any bias results in spurious interrupts. > > Fix this by modifying the `rockchip,pins` properties as necessary > to enable the pull-up resistors. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls commit: 9f6acd2b4dfef81dcc45486ac704cf602c88db02 Best regards,
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi index b517debf2b54..bbb6d38cd159 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi @@ -294,13 +294,13 @@ &pcie3x4 { &pinctrl { fan { fan_int: fan-int { - rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>; }; }; hym8563 { hym8563_int: hym8563-int { - rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>; }; };
The pinctrls for the hym8563 interrupt line and fan-tach input were both mistakenly defined as `pcfg_pull_none`. As these are active-low signals (level-triggered, in the hym8563 case) which may not be driven at times, these should really be pull-up. The lack of any bias results in spurious interrupts. Fix this by modifying the `rockchip,pins` properties as necessary to enable the pull-up resistors. Fixes: 2806a69f3fef6 ("arm64: dts: rockchip: Add Turing RK1 SoM support") Signed-off-by: Sam Edwards <CFSworks@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)