diff mbox series

[1/2] arm64: dts: rockchip: support poweroff on rock-5b

Message ID 20231225090856.3890-1-inindev@gmail.com (mailing list archive)
State New
Headers show
Series [1/2] arm64: dts: rockchip: support poweroff on rock-5b | expand

Commit Message

John Clark Dec. 25, 2023, 9:08 a.m. UTC 
Allow the rock-5b to poweroff its pmic.

related: c699fbfdfd54630fc51b96da577f02e7b772eb37

Signed-off-by: John Clark <inindev@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Dec. 25, 2023, 9:19 a.m. UTC | #1 
On 25/12/2023 10:08, John Clark wrote:
> Allow the rock-5b to poweroff its pmic.
> 
> related: c699fbfdfd54630fc51b96da577f02e7b772eb37

Reference commits how checkpatch and submitting-patches ask - commit foo
("bar") and explain what is "related".

Best regards,
Krzysztof
John Clark Dec. 25, 2023, 9:26 a.m. UTC | #2 
On 12/25/23 4:19 AM, Krzysztof Kozlowski wrote:
> On 25/12/2023 10:08, John Clark wrote:
>> Allow the rock-5b to poweroff its pmic.
>>
>> related: c699fbfdfd54630fc51b96da577f02e7b772eb37
> Reference commits how checkpatch and submitting-patches ask - commit foo
> ("bar") and explain what is "related".
>
> Best regards,
> Krzysztof
>
When issuing a "shutdown -h now" on the rock-5b it reboots instead.  
Using the 'system-power-controller' allows the rk806 to power down instead.
Krzysztof Kozlowski Dec. 25, 2023, 9:30 a.m. UTC | #3 
On 25/12/2023 10:26, John Clark wrote:
> On 12/25/23 4:19 AM, Krzysztof Kozlowski wrote:
>> On 25/12/2023 10:08, John Clark wrote:
>>> Allow the rock-5b to poweroff its pmic.
>>>
>>> related: c699fbfdfd54630fc51b96da577f02e7b772eb37
>> Reference commits how checkpatch and submitting-patches ask - commit foo
>> ("bar") and explain what is "related".
>>
>> Best regards,
>> Krzysztof
>>
> When issuing a "shutdown -h now" on the rock-5b it reboots instead.  
> Using the 'system-power-controller' allows the rk806 to power down instead.

I meant, explain in the commit msg.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 74719aaf697c..dc7b88f29172 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -426,6 +426,8 @@  pmic@0 {
 		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
 			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
 
+		system-power-controller;
+
 		vcc1-supply = <&vcc5v0_sys>;
 		vcc2-supply = <&vcc5v0_sys>;
 		vcc3-supply = <&vcc5v0_sys>;