| Message ID | 20231225102030.10617-1-inindev@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: rockchip: support poweroff on the rock-5b | expand |
On 25/12/2023 11:20, John Clark wrote: > Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on > the rock-5b it reboots instead. Using the 'system-power-controller' allows > the rk806 to power down instead. > > Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this > issue for the nanopc-t6. That's not the syntax I asked for. Where is its subject? Syntax is: commit foo ("subject"), respecting the length of SHA, as checked by checkpatch. You still miss v2 and changelog. I also wrote about this. b4 does it for you, but if you decide to use git manually, then you have to add it. Best regards, Krzysztof
On 12/25/23 5:43 AM, Krzysztof Kozlowski wrote: > On 25/12/2023 11:20, John Clark wrote: >> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on >> the rock-5b it reboots instead. Using the 'system-power-controller' allows >> the rk806 to power down instead. >> >> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this >> issue for the nanopc-t6. > That's not the syntax I asked for. Where is its subject? Syntax is: > commit foo ("subject"), respecting the length of SHA, as checked by > checkpatch. > > You still miss v2 and changelog. I also wrote about this. b4 does it for > you, but if you decide to use git manually, then you have to add it. > > Best regards, > Krzysztof > The documentation for --in-reply-to=<identifier> clearly states that it will generate the v2 semantics for the subject, yet it did not. I used the message-id from the first message since it was a two email patch to begin with. It is not clear to me why this did not happen. I will see if I can find a sandbox to practice my get-send-email skills in.
On 25/12/2023 11:51, John Clark wrote: > On 12/25/23 5:43 AM, Krzysztof Kozlowski wrote: >> On 25/12/2023 11:20, John Clark wrote: >>> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on >>> the rock-5b it reboots instead. Using the 'system-power-controller' allows >>> the rk806 to power down instead. >>> >>> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this >>> issue for the nanopc-t6. >> That's not the syntax I asked for. Where is its subject? Syntax is: >> commit foo ("subject"), respecting the length of SHA, as checked by >> checkpatch. >> >> You still miss v2 and changelog. I also wrote about this. b4 does it for >> you, but if you decide to use git manually, then you have to add it. >> >> Best regards, >> Krzysztof >> > The documentation for --in-reply-to=<identifier> clearly states that it No, it does not state that. > will generate the v2 semantics for the subject, yet it did not. I used Because it doesn't... > the message-id from the first message since it was a two email patch to Which you should not. Each submission is its own thread, which is already expressed: https://elixir.bootlin.com/linux/v6.7-rc7/source/Documentation/process/submitting-patches.rst#L782 > begin with. It is not clear to me why this did not happen. I will see > if I can find a sandbox to practice my get-send-email skills in. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index 74719aaf697c..dc7b88f29172 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -426,6 +426,8 @@ pmic@0 { pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, <&rk806_dvs2_null>, <&rk806_dvs3_null>; + system-power-controller; + vcc1-supply = <&vcc5v0_sys>; vcc2-supply = <&vcc5v0_sys>; vcc3-supply = <&vcc5v0_sys>;
Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on the rock-5b it reboots instead. Using the 'system-power-controller' allows the rk806 to power down instead. Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this issue for the nanopc-t6. Signed-off-by: John Clark <inindev@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++ 1 file changed, 2 insertions(+)