| Message ID | 20240327112120.1181570-1-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar | expand |
Hi Heiko, On 3/27/24 12:21, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Enable the mali gpu node and add the board-specific supply-regulator. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Thanks, Quentin
On Wed, 27 Mar 2024 12:21:19 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Enable the mali gpu node and add the board-specific supply-regulator. > > Applied, thanks! [1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar commit: 51ca6a22c52b10a787fa3fad2343279f11da27bb [2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger commit: f5256f8ed4b729c3ab9d9cd7d406313773484b59 Best regards,
On Wed, 27 Mar 2024 12:21:19 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > Enable the mali gpu node and add the board-specific supply-regulator. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > --- > arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3588-jaguar.dtb' for 20240327112120.1181570-1-heiko@sntech.de: Error: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts:248.1-5 Label or path gpu not found FATAL ERROR: Syntax error parsing input tree make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb] Error 1 make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2 make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-jaguar.dtb] Error 2 make: *** [Makefile:240: __sub-make] Error 2 make: Target 'rockchip/rk3588-jaguar.dtb' not remade because of errors.
Am Mittwoch, 27. März 2024, 16:41:16 CET schrieb Rob Herring: > > On Wed, 27 Mar 2024 12:21:19 +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@cherry.de> > > > > Enable the mali gpu node and add the board-specific supply-regulator. > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de> > > --- > > arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y rockchip/rk3588-jaguar.dtb' for 20240327112120.1181570-1-heiko@sntech.de: > > Error: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts:248.1-5 Label or path gpu not found > FATAL ERROR: Syntax error parsing input tree > make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb] Error 1 > make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2 > make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb' not remade because of errors. > make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-jaguar.dtb] Error 2 > make: *** [Makefile:240: __sub-make] Error 2 > make: Target 'rockchip/rk3588-jaguar.dtb' not remade because of errors. just for the record, that error fixes itself because the patch gets applied only after the main series adding that gpu node ;-) Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts index b564c7494878..d422bab41b82 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts @@ -253,6 +253,11 @@ mdot2e-w-disable2-n-hog { }; }; +&gpu { + mali-supply = <&vdd_gpu_s0>; + status = "okay"; +}; + &i2c0 { pinctrl-0 = <&i2c0m2_xfer>; status = "okay";