diff mbox series

[v4,2/3] dt-bindings: arm: rockchip: Add ArmSoM Sige7

Message ID 20240416034626.317823-3-liujianfeng1994@gmail.com (mailing list archive)
State New
Headers show
Series Add ArmSom Sige7 board | expand

Commit Message

Jianfeng Liu April 16, 2024, 3:46 a.m. UTC 
Add devicetree binding for ArmSoM Sige7 board

Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Weizhao Ouyang April 16, 2024, 11:11 a.m. UTC | #1 
On Tue, Apr 16, 2024 at 11:46 AM Jianfeng Liu <liujianfeng1994@gmail.com> wrote:
>
> Add devicetree binding for ArmSoM Sige7 board
>
> Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Weizhao Ouyang <weizhao.ouyang@arm.com>

BR,
Weizhao

> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 4bd033ade..fd644e32c 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -49,6 +49,11 @@ properties:
>                - anbernic,rg-arc-s
>            - const: rockchip,rk3566
>
> +      - description: ArmSoM Sige7 board
> +        items:
> +          - const: armsom,sige7
> +          - const: rockchip,rk3588
> +
>        - description: Asus Tinker board
>          items:
>            - const: asus,rk3288-tinker
> --
> 2.34.1
>
Krzysztof Kozlowski April 17, 2024, 1:24 p.m. UTC | #2 
On 16/04/2024 13:11, Weizhao Ouyang wrote:
> On Tue, Apr 16, 2024 at 11:46 AM Jianfeng Liu <liujianfeng1994@gmail.com> wrote:
>>
>> Add devicetree binding for ArmSoM Sige7 board
>>
>> Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
>> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Reviewed-by: Weizhao Ouyang <weizhao.ouyang@arm.com>

This does not match your email. What did you exactly review here?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 4bd033ade..fd644e32c 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -49,6 +49,11 @@  properties:
               - anbernic,rg-arc-s
           - const: rockchip,rk3566
 
+      - description: ArmSoM Sige7 board
+        items:
+          - const: armsom,sige7
+          - const: rockchip,rk3588
+
       - description: Asus Tinker board
         items:
           - const: asus,rk3288-tinker