diff mbox series

[2/3] arm64: dts: rockchip: prepare common .dtsi for Radxa ROCK Pi E

Message ID 20240623120016.82990-2-naoki@radxa.com (mailing list archive)
State New
Headers show
Series [1/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E v3.0 | expand

Commit Message

FUKAUMI Naoki June 23, 2024, noon UTC
Radxa ROCK Pi E v1.2x and ROCK Pi E v3.0 share most of their parts.
prepare rk3328-rock-pi-e-base.dtsi as a common dtsi for both boards.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 .../{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi}       | 3 ---
 1 file changed, 3 deletions(-)
 rename arch/arm64/boot/dts/rockchip/{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi} (99%)

Comments

Krzysztof Kozlowski June 23, 2024, 12:09 p.m. UTC | #1
On 23/06/2024 14:00, FUKAUMI Naoki wrote:
> Radxa ROCK Pi E v1.2x and ROCK Pi E v3.0 share most of their parts.
> prepare rk3328-rock-pi-e-base.dtsi as a common dtsi for both boards.
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  .../{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi}       | 3 ---
>  1 file changed, 3 deletions(-)
>  rename arch/arm64/boot/dts/rockchip/{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi} (99%)

This breaks users and is not bisectable.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-base.dtsi
similarity index 99%
rename from arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
rename to arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-base.dtsi
index a608a219543e..b2c5089ad2f8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-base.dtsi
@@ -17,9 +17,6 @@ 
 #include "rk3328.dtsi"
 
 / {
-	model = "Radxa ROCK Pi E";
-	compatible = "radxa,rockpi-e", "rockchip,rk3328";
-
 	aliases {
 		ethernet0 = &gmac2io;
 		ethernet1 = &gmac2phy;