| Message ID | 20240714112851.1048184-1-andyshrk@163.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: arm: rockchip: Add Cool Pi GenBook | expand |
Hello Andy, Please see a comment below. On 2024-07-14 13:28, Andy Yan wrote: > Add Cool Pi GenBook, a laptop powered by RK3588 > > Cool Pi GenBook works with a mother board connect > with CM5 > > Signed-off-by: Andy Yan <andyshrk@163.com> > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml > b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 1ef09fbfdfaf..e4f2ae9ec457 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -96,6 +96,14 @@ properties: > - const: coolpi,pi-cm5 > - const: rockchip,rk3588 > > + - description: Cool Pi GenBook > + items: > + - enum: > + - coolpi,genbook > + - const: coolpi,pi-cm5 The system on module (SoM) used in the GenBook is actually called GenM5, according to the product announcement [1] and the SoM schematic. [2] [1] https://www.crowdsupply.com/shenzhen-tianmao-technology-co-ltd/genbook-rk3588 [2] https://wiki.cool-pi.com/notebook/coolpi-genm5-schematic-v20.pdf > + - const: rockchip,rk3588 > + > + > - description: Cool Pi 4 Model B > items: > - const: coolpi,pi-4b
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 1ef09fbfdfaf..e4f2ae9ec457 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -96,6 +96,14 @@ properties: - const: coolpi,pi-cm5 - const: rockchip,rk3588 + - description: Cool Pi GenBook + items: + - enum: + - coolpi,genbook + - const: coolpi,pi-cm5 + - const: rockchip,rk3588 + + - description: Cool Pi 4 Model B items: - const: coolpi,pi-4b
Add Cool Pi GenBook, a laptop powered by RK3588 Cool Pi GenBook works with a mother board connect with CM5 Signed-off-by: Andy Yan <andyshrk@163.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)