| Message ID | 20240801-b4-rk3588-bridge-upstream-v2-2-9fa657a4e15b@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add initial support for the Rockchip RK3588 HDMI TX Controller | expand |
On 01/08/2024 04:25, Cristian Ciocaltea wrote: > Driver makes use of the BIT() macro, but relies on the bits header being > implicitly included. > > Explicitly pull the header in to avoid potential build failures in some > configurations. > > While at it, reorder include directives alphabetically. > > Fixes: 8c8546546f25 ("drm/rockchip: move output interface related definition to rockchip_drm_drv.h") There is no bug here to be fixed. Drop. Especially bugfixes should not be combined with cleanups. Best regards, Krzysztof
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h index bbb9e0bf6804..8d566fcd80a2 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.h +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.h @@ -12,9 +12,10 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_gem.h> +#include <linux/bits.h> +#include <linux/component.h> #include <linux/i2c.h> #include <linux/module.h> -#include <linux/component.h> #define ROCKCHIP_MAX_FB_BUFFER 3 #define ROCKCHIP_MAX_CONNECTOR 2
Driver makes use of the BIT() macro, but relies on the bits header being implicitly included. Explicitly pull the header in to avoid potential build failures in some configurations. While at it, reorder include directives alphabetically. Fixes: 8c8546546f25 ("drm/rockchip: move output interface related definition to rockchip_drm_drv.h") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)