diff mbox series

[10/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 5A

Message ID 20240808093808.1740-11-naoki@radxa.com (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards | expand

Commit Message

FUKAUMI Naoki Aug. 8, 2024, 9:38 a.m. UTC 
- add default-state
- change function from STATUS to HEARTBEAT

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Aug. 8, 2024, 10:54 a.m. UTC | #1 
On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - add default-state
> - change function from STATUS to HEARTBEAT

Why? Explain in ALL YOUR COMMITS why you are doing this.

What you are doing is visible from the diff.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index 03ed48246d36..17364582297d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -42,7 +42,8 @@  leds {
 
 		io-led {
 			color = <LED_COLOR_ID_BLUE>;
-			function = LED_FUNCTION_STATUS;
+			default-state = "on";
+			function = LED_FUNCTION_HEARTBEAT;
 			gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};