diff mbox series

[03/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK 4C+

Message ID 20240808093808.1740-4-naoki@radxa.com (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards | expand

Commit Message

FUKAUMI Naoki Aug. 8, 2024, 9:38 a.m. UTC 
- sort properties
- add default-state
- change function for led-1 from STATUS to HEARTBEAT

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Aug. 8, 2024, 10:52 a.m. UTC | #1 
On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - sort properties

Please, stop. This makes no sense.

> - add default-state
> - change function for led-1 from STATUS to HEARTBEAT

Don't mix changes.



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts
index d4b4dced3e39..7454bfb76a7d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts
@@ -37,16 +37,18 @@  leds {
 
 		/* USER_LED1 */
 		led-0 {
-			function = LED_FUNCTION_POWER;
 			color = <LED_COLOR_ID_GREEN>;
+			default-state = "on";
+			function = LED_FUNCTION_POWER;
 			gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>;
 			linux,default-trigger = "default-on";
 		};
 
 		/* USER_LED2 */
 		led-1 {
-			function = LED_FUNCTION_STATUS;
 			color = <LED_COLOR_ID_BLUE>;
+			default-state = "on";
+			function = LED_FUNCTION_HEARTBEAT;
 			gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};