| Message ID | 20240808093808.1740-8-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards | expand |
On 08/08/2024 11:38, FUKAUMI Naoki wrote: > - sort properties > - add default-state > - add function for multi-led > - remove redundant parameters from pwms This does not match commit subject at all. Anyway, one commit per logical change. Trivial cleanups are not per board, but per entire subsystem. Changes with impact can be per board. The way you split your work makes review, bisecting and backporting unnecessary difficult. It's not even logical. There is no logical change like "I will do 10 things for board X". Best regards, Krzysztof
On 08/08/2024 11:38, FUKAUMI Naoki wrote: > - sort properties > - add default-state > - add function for multi-led > - remove redundant parameters from pwms Why redundant? I don't think this was tested. :( Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi index 45b03dcbbad4..b287d9cca6f9 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi @@ -20,9 +20,10 @@ gpio-leds { compatible = "gpio-leds"; led_user: led-0 { - gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; - function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; + function = LED_FUNCTION_HEARTBEAT; + gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>; diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts index 72ad74c38a2b..4b5203c0037a 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts @@ -16,21 +16,22 @@ pwm-leds { multi-led { color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_ACTIVITY; max-brightness = <255>; led-red { color = <LED_COLOR_ID_RED>; - pwms = <&pwm1 0 1000000 0>; + pwms = <&pwm1 0 1000000>; }; led-green { color = <LED_COLOR_ID_GREEN>; - pwms = <&pwm2 0 1000000 0>; + pwms = <&pwm2 0 1000000>; }; led-blue { color = <LED_COLOR_ID_BLUE>; - pwms = <&pwm12 0 1000000 0>; + pwms = <&pwm12 0 1000000>; }; }; };
- sort properties - add default-state - add function for multi-led - remove redundant parameters from pwms Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 5 +++-- arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 7 ++++--- 2 files changed, 7 insertions(+), 5 deletions(-)