| Message ID | 20240826075130.546-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A | expand |
On Mon, 26 Aug 2024 16:51:29 +0900, FUKAUMI Naoki wrote: > There is no "on-board WLAN/BT chip" on Radxa ROCK 5A. remove related > properties. > > Applied, thanks! [1/1] arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A commit: b8ac0cf405c2092decc5cc102ed3a2d5d3200ab4 Best regards,
Hi, On Wed, Aug 28, 2024 at 05:14:14PM GMT, Heiko Stuebner wrote: > On Mon, 26 Aug 2024 16:51:29 +0900, FUKAUMI Naoki wrote: > > There is no "on-board WLAN/BT chip" on Radxa ROCK 5A. remove related > > properties. > > Applied, thanks! > > [1/1] arm64: dts: rockchip: remove unnecessary properties for Radxa ROCK 5A > commit: b8ac0cf405c2092decc5cc102ed3a2d5d3200ab4 Oops, good find. I didn't notice this feature did not make it into the final ROCK 5A. I have a pre-production version of this board (which does have a WLAN/BT chip). I did notice that the M.2 slot was changed between my version and the one being sold, that's why I never send PCIe patches. That might be something for you to look into Naoki? Greetings, -- Sebastian
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts index 03ed48246d36..953a722198fe 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts @@ -317,28 +317,6 @@ vcc5v0_host_en: vcc5v0-host-en { rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>; }; }; - - wifibt { - wl_reset: wl-reset { - rockchip,pins = <0 RK_PD0 RK_FUNC_GPIO &pcfg_pull_up>; - }; - - wl_dis: wl-dis { - rockchip,pins = <0 RK_PD5 RK_FUNC_GPIO &pcfg_output_high>; - }; - - wl_wake_host: wl-wake-host { - rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>; - }; - - bt_dis: bt-dis { - rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_output_high>; - }; - - bt_wake_host: bt-wake-host { - rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>; - }; - }; }; &pwm3 { @@ -754,8 +732,6 @@ &usbdp_phy0 { &usb_host0_ehci { status = "okay"; - pinctrl-names = "default"; - pinctrl-0 = <&wl_reset &wl_dis &wl_wake_host &bt_dis &bt_wake_host>; }; &usb_host0_ohci {
There is no "on-board WLAN/BT chip" on Radxa ROCK 5A. remove related properties. Fixes: 1642bf66e270 ("arm64: dts: rockchip: add USB2 to rk3588s-rock5a") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- .../boot/dts/rockchip/rk3588s-rock-5a.dts | 24 ------------------- 1 file changed, 24 deletions(-)