| Message ID | 20240903105245.715899-6-karthikeyan@linumiz.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support Relfor Saib board which is based on Rockchip RV1109 SoC | expand |
On 03/09/2024 12:52, Karthikeyan Krishnasamy wrote: > consume clkout from rv3028 rtc which is able to provide > different clock frequency upon configuration > > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> > --- > > Notes: > v2: > - fix commit message subject <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 9/3/24 18:21, Krzysztof Kozlowski wrote: > On 03/09/2024 12:52, Karthikeyan Krishnasamy wrote: >> consume clkout from rv3028 rtc which is able to provide >> different clock frequency upon configuration >> >> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> >> --- >> >> Notes: >> v2: >> - fix commit message subject > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof > Apologies. I'm new to the process, somewhat i'm missing this information. I will change it in the future patches. Thanks for suggesting b4, i will look into it. Best regards, Karthikeyan
On Tue, Sep 03, 2024 at 04:22:42PM +0530, Karthikeyan Krishnasamy wrote: > consume clkout from rv3028 rtc which is able to provide > different clock frequency upon configuration Please write complete sentences. The subject is wrong. There is no such property 'clock-cells'. > > Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> > --- > > Notes: > v2: > - fix commit message subject > > Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > index 5ade5dfad048..cda8ad7c1203 100644 > --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml > @@ -22,6 +22,9 @@ properties: > interrupts: > maxItems: 1 > > + "#clock-cells": > + const: 0 > + > trickle-resistor-ohms: > enum: > - 3000 > -- > 2.39.2 >
On 9/3/24 20:15, Rob Herring wrote: > On Tue, Sep 03, 2024 at 04:22:42PM +0530, Karthikeyan Krishnasamy wrote: >> consume clkout from rv3028 rtc which is able to provide >> different clock frequency upon configuration > > Please write complete sentences. > > The subject is wrong. There is no such property 'clock-cells'. I will updated in next version. Thanks. > >> >> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> >> --- >> >> Notes: >> v2: >> - fix commit message subject >> >> Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> index 5ade5dfad048..cda8ad7c1203 100644 >> --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml >> @@ -22,6 +22,9 @@ properties: >> interrupts: >> maxItems: 1 >> >> + "#clock-cells": >> + const: 0 >> + >> trickle-resistor-ohms: >> enum: >> - 3000 >> -- >> 2.39.2 >> Best regards, Karthikeyan
diff --git a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml index 5ade5dfad048..cda8ad7c1203 100644 --- a/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml +++ b/Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml @@ -22,6 +22,9 @@ properties: interrupts: maxItems: 1 + "#clock-cells": + const: 0 + trickle-resistor-ohms: enum: - 3000
consume clkout from rv3028 rtc which is able to provide different clock frequency upon configuration Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com> --- Notes: v2: - fix commit message subject Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 3 +++ 1 file changed, 3 insertions(+)