| Message ID | 20241008203940.2573684-4-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fixing some dtbscheck warnings | expand |
Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > The expected clock-name is different, and extclk also is deprecated > in favor of txco for clocks that are not crystals. > > The wakeup gpio properties are named differently too, when changing > from vendor-tree to mainline. So fix those to match the binding. > > Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip > rk3566 box demo board") > Cc: Andy Yan <andyshrk@163.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> Looking good to me, thanks for the patch. I've got these changes cross-referenced to what's expected in drivers/bluetooth/hci_bcm.c, and it's all fine. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > index 0c18406e4c59..7d4680933823 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > @@ -449,9 +449,9 @@ &uart1 { > bluetooth { > compatible = "brcm,bcm43438-bt"; > clocks = <&pmucru CLK_RTC_32K>; > - clock-names = "ext_clock"; > - device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; > - host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; > + clock-names = "txco"; > + device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; > + host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; > shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>; > pinctrl-names = "default"; > pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 0c18406e4c59..7d4680933823 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -449,9 +449,9 @@ &uart1 { bluetooth { compatible = "brcm,bcm43438-bt"; clocks = <&pmucru CLK_RTC_32K>; - clock-names = "ext_clock"; - device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; - host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; + clock-names = "txco"; + device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>; + host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>; shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
The expected clock-name is different, and extclk also is deprecated in favor of txco for clocks that are not crystals. The wakeup gpio properties are named differently too, when changing from vendor-tree to mainline. So fix those to match the binding. Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board") Cc: Andy Yan <andyshrk@163.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)