| Message ID | 20241019-es8328-dt-fixes-v1-1-ca77d5ce21ad@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Drop invalid clock-names from es8388 codec nodes | expand |
On Sat, 19 Oct 2024 03:38:10 +0300, Cristian Ciocaltea wrote: > The binding for Everest ES8328/ES8388 audio CODEC doesn't support the > 'clock-names' property: > > rk3588-orangepi-5-plus.dtb: audio-codec@11: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml# > > Since the related audio driver is also not making use of it, drop the > invalid property from all es8388 codec nodes. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Drop invalid clock-names from es8388 codec nodes commit: 6df447d57800b7f9adb8eb673f1853331be20bb3 Best regards,
On Sat, 19 Oct 2024 03:38:10 +0300, Cristian Ciocaltea wrote: > The binding for Everest ES8328/ES8388 audio CODEC doesn't support the > 'clock-names' property: > > rk3588-orangepi-5-plus.dtb: audio-codec@11: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml# > > Since the related audio driver is also not making use of it, drop the > invalid property from all es8388 codec nodes. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > Several DT fixes involving the usage of the Everest ES8328/ES8388 audio > CODEC. > --- > arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 1 - > arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 1 - > 4 files changed, 4 deletions(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3399-roc-pc-plus.dtb rockchip/rk3588-orangepi-5-plus.dtb rockchip/rk3588-quartzpro64.dtb rockchip/rk3588s-indiedroid-nova.dtb' for 20241019-es8328-dt-fixes-v1-1-ca77d5ce21ad@collabora.com: arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: audio-codec@11: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#
On 10/21/24 8:58 PM, Rob Herring (Arm) wrote: > > On Sat, 19 Oct 2024 03:38:10 +0300, Cristian Ciocaltea wrote: >> The binding for Everest ES8328/ES8388 audio CODEC doesn't support the >> 'clock-names' property: >> >> rk3588-orangepi-5-plus.dtb: audio-codec@11: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml# >> >> Since the related audio driver is also not making use of it, drop the >> invalid property from all es8388 codec nodes. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >> --- >> Several DT fixes involving the usage of the Everest ES8328/ES8388 audio >> CODEC. >> --- >> arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 1 - >> arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 1 - >> arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 1 - >> arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 1 - >> 4 files changed, 4 deletions(-) >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y rockchip/rk3399-roc-pc-plus.dtb rockchip/rk3588-orangepi-5-plus.dtb rockchip/rk3588-quartzpro64.dtb rockchip/rk3588s-indiedroid-nova.dtb' for 20241019-es8328-dt-fixes-v1-1-ca77d5ce21ad@collabora.com: > > arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: audio-codec@11: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml# This warning is unrelated, but eventually fixed via: https://lore.kernel.org/lkml/20241019-es8328-doc-port-v1-1-25c1d1b5c65c@collabora.com/ Regards, Cristian
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts index 2c41e017f4f402e9c7eea80955219ee23f2f582d..ca1d3253d3e1f4c6f272a27737b5660c099538e5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts @@ -114,7 +114,6 @@ &i2c1 { es8388: es8388@11 { compatible = "everest,es8388"; reg = <0x11>; - clock-names = "mclk"; clocks = <&cru SCLK_I2S_8CH_OUT>; #sound-dai-cells = <0>; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts index c73fecf1c73c94944bb25e1243d5390b84241338..4cfce107be73652ba5eb2c03e3e2ca0c65ed5d50 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts @@ -328,7 +328,6 @@ es8388: audio-codec@11 { compatible = "everest,es8388"; reg = <0x11>; clocks = <&cru I2S0_8CH_MCLKOUT>; - clock-names = "mclk"; AVDD-supply = <&vcc_1v8_s0>; DVDD-supply = <&vcc_1v8_s0>; HPVDD-supply = <&vcc_3v3_s0>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts b/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts index 50c7a5e9af1904b87925bc526752a87deb3460a6..177e00d45b3d19e91525e62b5ce40d1079bea330 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts @@ -316,7 +316,6 @@ es8388: audio-codec@11 { assigned-clocks = <&cru I2S0_8CH_MCLKOUT>; assigned-clock-rates = <12288000>; clocks = <&cru I2S0_8CH_MCLKOUT>; - clock-names = "mclk"; AVDD-supply = <&avcc_1v8_codec_s0>; DVDD-supply = <&avcc_1v8_codec_s0>; HPVDD-supply = <&vcc_3v3_s0>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts index d8c50fdcca3b57e50d70325e1d7a7efad2e314bd..8ba111d9283fefcf77093be7f74705d06f67edfa 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts @@ -377,7 +377,6 @@ es8388: audio-codec@11 { assigned-clock-rates = <12288000>; assigned-clocks = <&cru I2S0_8CH_MCLKOUT>; AVDD-supply = <&vcc_3v3_s3>; - clock-names = "mclk"; clocks = <&cru I2S0_8CH_MCLKOUT>; DVDD-supply = <&vcc_1v8_s3>; HPVDD-supply = <&vcc_3v3_s3>;
The binding for Everest ES8328/ES8388 audio CODEC doesn't support the 'clock-names' property: rk3588-orangepi-5-plus.dtb: audio-codec@11: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml# Since the related audio driver is also not making use of it, drop the invalid property from all es8388 codec nodes. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- Several DT fixes involving the usage of the Everest ES8328/ES8388 audio CODEC. --- arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 1 - arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 1 - arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 1 - arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 1 - 4 files changed, 4 deletions(-) --- base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3 change-id: 20241019-es8328-dt-fixes-e2bcd2a80a74