diff mbox series

[1/8] arm64: dts: rockchip: fix eeprom for Radxa ROCK 5A

Message ID 20241113081258.2745-1-naoki@radxa.com (mailing list archive)
State New
Headers show
Series [1/8] arm64: dts: rockchip: fix eeprom for Radxa ROCK 5A | expand

Commit Message

FUKAUMI Naoki Nov. 13, 2024, 8:12 a.m. UTC
- move eeprom from i2c2 to i2c0 to match with schematic[1]
- add vcc_3v3_pmu regulator and use it as vcc-supply for eeprom

[1] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 .../boot/dts/rockchip/rk3588s-rock-5a.dts     | 23 ++++++++++++++-----
 1 file changed, 17 insertions(+), 6 deletions(-)

Comments

FUKAUMI Naoki Nov. 13, 2024, 12:21 p.m. UTC | #1
Hi,

please ignore this patchset for Radxa ROCK 5A.

ROCK 5C is slightly updated version of ROCK 5A, and they are 99% 
identical from the perspective of device tree.

(if you want, you can use rk3588s-rock-5c.dts(dtb) for ROCK 5A)

I'll update ROCK 5C patchset to make commin .dtsi, then convert both 
ROCK 5A and 5C dts to use common (and up-to-date) .dtsi.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

On 11/13/24 17:12, FUKAUMI Naoki wrote:
> - move eeprom from i2c2 to i2c0 to match with schematic[1]
> - add vcc_3v3_pmu regulator and use it as vcc-supply for eeprom
> 
> [1] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>   .../boot/dts/rockchip/rk3588s-rock-5a.dts     | 23 ++++++++++++++-----
>   1 file changed, 17 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> index 70a43432bdc5..56c818c45dc0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> @@ -113,6 +113,16 @@ vcc5v0_sys: regulator-vcc5v0-sys {
>   		vin-supply = <&vcc12v_dcin>;
>   	};
>   
> +	vcc_3v3_pmu: regulator-vcc-3v3-pmu {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc_3v3_pmu";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		vin-supply = <&vcc_3v3_s3>;
> +	};
> +
>   	vcc_5v0: regulator-vcc-5v0 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "vcc_5v0";
> @@ -221,6 +231,13 @@ regulator-state-mem {
>   			regulator-off-in-suspend;
>   		};
>   	};
> +
> +	eeprom: eeprom@50 {
> +		compatible = "belling,bl24c16a", "atmel,24c16";
> +		reg = <0x50>;
> +		pagesize = <16>;
> +		vcc-supply = <&vcc_3v3_pmu>;
> +	};
>   };
>   
>   &i2c2 {
> @@ -242,12 +259,6 @@ regulator-state-mem {
>   			regulator-off-in-suspend;
>   		};
>   	};
> -
> -	eeprom: eeprom@50 {
> -		compatible = "belling,bl24c16a", "atmel,24c16";
> -		reg = <0x50>;
> -		pagesize = <16>;
> -	};
>   };
>   
>   &i2c3 {
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
index 70a43432bdc5..56c818c45dc0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
@@ -113,6 +113,16 @@  vcc5v0_sys: regulator-vcc5v0-sys {
 		vin-supply = <&vcc12v_dcin>;
 	};
 
+	vcc_3v3_pmu: regulator-vcc-3v3-pmu {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_3v3_pmu";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc_3v3_s3>;
+	};
+
 	vcc_5v0: regulator-vcc-5v0 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_5v0";
@@ -221,6 +231,13 @@  regulator-state-mem {
 			regulator-off-in-suspend;
 		};
 	};
+
+	eeprom: eeprom@50 {
+		compatible = "belling,bl24c16a", "atmel,24c16";
+		reg = <0x50>;
+		pagesize = <16>;
+		vcc-supply = <&vcc_3v3_pmu>;
+	};
 };
 
 &i2c2 {
@@ -242,12 +259,6 @@  regulator-state-mem {
 			regulator-off-in-suspend;
 		};
 	};
-
-	eeprom: eeprom@50 {
-		compatible = "belling,bl24c16a", "atmel,24c16";
-		reg = <0x50>;
-		pagesize = <16>;
-	};
 };
 
 &i2c3 {