| Message ID | 20241119132916.1057797-4-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | RK3576 OTP support | expand |
On Tue, Nov 19, 2024 at 02:29:14PM +0100, Heiko Stuebner wrote: > Document the OTP memory found on Rockchip RK3576 SoC. > > The RK3576 uses the same set of clocks as the px30/rk3308 > but has one reset more, so adapt the binding to handle this > variant as well. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > .../bindings/nvmem/rockchip,otp.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml > index a44d44b32809..dae7543a0179 100644 > --- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml > +++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - rockchip,px30-otp > - rockchip,rk3308-otp > + - rockchip,rk3576-otp > - rockchip,rk3588-otp > > reg: > @@ -68,6 +69,23 @@ allOf: > items: > - const: phy > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3576-otp > + then: > + properties: > + clocks: > + minItems: 3 That's redundant. 3 is there already. You wanted maxItems? Missing constraint on clock-names (existing binding should be fixed as well, separate patch). > + resets: > + minItems: 2 missing maxItems > + reset-names: > + items: > + - const: otp > + - const: apb Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml index a44d44b32809..dae7543a0179 100644 --- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml +++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml @@ -14,6 +14,7 @@ properties: enum: - rockchip,px30-otp - rockchip,rk3308-otp + - rockchip,rk3576-otp - rockchip,rk3588-otp reg: @@ -68,6 +69,23 @@ allOf: items: - const: phy + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3576-otp + then: + properties: + clocks: + minItems: 3 + resets: + minItems: 2 + reset-names: + items: + - const: otp + - const: apb + - if: properties: compatible:
Document the OTP memory found on Rockchip RK3576 SoC. The RK3576 uses the same set of clocks as the px30/rk3308 but has one reset more, so adapt the binding to handle this variant as well. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- .../bindings/nvmem/rockchip,otp.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)