From patchwork Mon Dec 23 01:39:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: FUKAUMI Naoki X-Patchwork-Id: 13918353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F324EE77190 for ; Mon, 23 Dec 2024 01:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LAV0wZT44X1bUyN63NDne6OWMm3MxZcUqvTkUiPIRUE=; b=3iQ/KGMDY7TIpB T4HHeNGirerFg0X9GvhmX6QgUA+JYc/PmfNtpLQHbsC6LyNLr1WBwtnpkkNavjaeycjcbUyGx+sz3 5kFYtc+/Od890R8rLS84NbUdvXqFJ4l2uOT43QdnugkFTeEIExhV6Zl8Cp12NqLT2YSpic4MY8TN0 717V2YmY+ZVAgUyOw42Pov8oiDPQB5Dk+g1FEFuD1L4KqLmmZ3WDl3AV3fWJ47CIKEC0B9wp71TUN u3fIbEnK6LTT6byWb9EHHRdiuEuoeOmeHUtKWs5c9UqK5PGvp0UNaOrjiABo4O8Yy0gYVL2ll8tNv +rUVnD1J6AL/glqRxObg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tPXQD-000000095gL-4A5z; Mon, 23 Dec 2024 01:39:49 +0000 Received: from sakura.naobsd.org ([160.16.200.221] helo=mail.naobsd.org) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tPXQ7-000000095b6-1BIe for linux-rockchip@lists.infradead.org; Mon, 23 Dec 2024 01:39:46 +0000 Received: from secure.fukaumi.org ([10.0.0.2]) by mail.naobsd.org (8.14.4/8.14.4/Debian-4.1ubuntu1.1) with ESMTP id 4BN1dW71024519; Mon, 23 Dec 2024 10:39:33 +0900 From: FUKAUMI Naoki To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dsimic@manjaro.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, FUKAUMI Naoki Subject: [PATCH v6 2/7] arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C Date: Mon, 23 Dec 2024 01:39:21 +0000 Message-ID: <20241223013926.1134-3-naoki@radxa.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241223013926.1134-1-naoki@radxa.com> References: <20241223013926.1134-1-naoki@radxa.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241222_173943_539754_EC67799C X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a total switch-on time of 0,6us and a total switch-off time of 6us [1], meaning that the current PWM period of just 10us is too short for fine-grained fan speed control. Increase the PWM period to 60us, so that the switch-on and switch-off time of the MOSFET fall within a more reasonable ~10% of the full period, thus making lower PWM duty cycles meaningful. [1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") Signed-off-by: FUKAUMI Naoki --- Changes in v6: - none Changes in v5: - Reword commit message (Alexey Charkov) Changes in v4: - none Changes in v3: - none Changes in v2: - Reword commit message --- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts index 23e9b447b6f0..910ec67bd4eb 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts @@ -73,7 +73,7 @@ fan { #cooling-cells = <2>; cooling-levels = <0 64 128 192 255>; fan-supply = <&vcc_5v0>; - pwms = <&pwm3 0 10000 0>; + pwms = <&pwm3 0 60000 0>; }; pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {