From patchwork Tue Dec 31 09:07:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Yan X-Patchwork-Id: 13923697 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10055E77188 for ; Tue, 31 Dec 2024 09:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q8bG9OTFSlQ8FqLnKjCCpgXN8lhGQl//abAqt419xRY=; b=eeARjuApGlo3JU BtnqIgtCaEBYE69tc2g3jHxNaVpzPoYS4sE1ie+gWvAWZqiP0mS1HR7PEz2J44xwgDy8qGnsMLsNn AqPxLZUI+jFkS0Z490IIJVYT4ar7CzLTWLVcR1OsQ9KPPAGSkjJkPVFAXBIlFEFxzbhnUBxVciy8I iSl/Vhaa3gT+FzV8a3PIUYdQrMO9hz3FHpIZWsQxJ8b+3nmXMnaulPmoFoPPMEYGb+OBr0DBvlKHt HpJV0mBY5yW+Mn3PLBfFs6FnEnEYB6BvEkLMKYHE7ALeo+rXECIdlNWo4lF+Uyuf/flfGu+Js+8/L TdAhsFExY5or69n0SAyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tSYHL-00000006tnj-08a7; Tue, 31 Dec 2024 09:11:07 +0000 Received: from m16.mail.163.com ([117.135.210.2]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tSYEo-00000006t23-34Ia; Tue, 31 Dec 2024 09:08:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=pD4rY OtR+d4vlbX2pPWDBCcK4oO1gPjv+46RQN4HNss=; b=lYDCGZg/k3paIwcb+39e7 WkVvKh7dv7rqxEogn3VJK7O0qc22QkF+2rurAUvmCIXfV4HkjOg+Qkmr5adWhSEt WOQvqXZpwcgE7aGOeuqLcOnsUFNQIM1+N+/0a7zG3erloNjJ2K/dsU0D3CvGtB5q LZqLBDQx6EyxSxz4m7xWpc= Received: from ProDesk.. (unknown []) by gzga-smtp-mtada-g0-2 (Coremail) with SMTP id _____wBHEQp0tHNnooOKCw--.15748S10; Tue, 31 Dec 2024 17:08:16 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, krzk+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, detlev.casanova@collabora.com, daniel@fooishbar.org, Andy Yan Subject: [PATCH v8 8/9] dt-bindings: display: vop2: Add rk3576 support Date: Tue, 31 Dec 2024 17:07:51 +0800 Message-ID: <20241231090802.251787-9-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241231090802.251787-1-andyshrk@163.com> References: <20241231090802.251787-1-andyshrk@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wBHEQp0tHNnooOKCw--.15748S10 X-Coremail-Antispam: 1Uf129KBjvJXoWxWr1kWFyDJrW8ZFyrGFyxAFb_yoW5KFWxpa 93CFyDXrW8Gr1UXw4ktF1rCws5tFn0yw4Ykrn7ta17KrsxtF48Ww1agrn8Xr13Wry7ZayY 9FsYk347G3savrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UZFxUUUUUU= X-Originating-IP: [58.22.7.114] X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/1tbiqQDGXmdzq1zveAACsH X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241231_010831_203934_BF004D91 X-CRM114-Status: UNSURE ( 9.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Andy Yan Add vop found on rk3576, the main difference between rk3576 and the previous vop is that each VP has its own interrupt line. Signed-off-by: Andy Yan --- Changes in v8: - Fix dt_binding_check errors - ordered by soc name - Link to the previous version: https://lore.kernel.org/linux-rockchip/6pn3qjxotdtpzucpul24yro7ppddezwuizneovqvmgdwyv2j7p@ztg4mqyiqmjf/T/#u Changes in v4: - describe constraint SOC by SOC, as interrupts of rk3576 is very different from others - Drop Krzysztof's Reviewed-by, as this version changed a lot. Changes in v3: - ordered by soc name - Add description for newly added interrupt Changes in v2: - Add dt bindings .../display/rockchip/rockchip-vop2.yaml | 81 ++++++++++++++----- 1 file changed, 63 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 2531726af306..4cdd9cced10c 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml @@ -20,6 +20,7 @@ properties: enum: - rockchip,rk3566-vop - rockchip,rk3568-vop + - rockchip,rk3576-vop - rockchip,rk3588-vop reg: @@ -37,10 +38,21 @@ properties: - const: gamma-lut interrupts: - maxItems: 1 + minItems: 1 + maxItems: 4 description: - The VOP interrupt is shared by several interrupt sources, such as - frame start (VSYNC), line flag and other status interrupts. + For VOP version under rk3576, the interrupt is shared by several interrupt + sources, such as frame start (VSYNC), line flag and other interrupt status. + For VOP version from rk3576 there is a system interrupt for bus error, and + every video port has it's independent interrupts for vsync and other video + port related error interrupts. + + interrupt-names: + items: + - const: vop-sys + - const: vop-vp0 + - const: vop-vp1 + - const: vop-vp2 # See compatible-specific constraints below. clocks: @@ -120,43 +132,76 @@ allOf: properties: compatible: contains: - const: rockchip,rk3588-vop + enum: + - rockchip,rk3566-vop + - rockchip,rk3568-vop then: properties: clocks: - minItems: 7 + minItems: 5 clock-names: - minItems: 7 - + minItems: 5 ports: required: - port@0 - port@1 - port@2 - - port@3 + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3576-vop + then: + properties: + clocks: + minItems: 5 + clock-names: + minItems: 5 + ports: + required: + - port@0 + - port@1 + - port@2 + interrupts: + items: + - description: vop system interrupt, such as axi bus error + - description: interrupts for video port0, such as vsync, dsp_hold. + - description: interrupts for video port1, such as vsync, dsp_hold. + - description: interrupts for video port2, such as vsync, dsp_hold. + interrupt-names: + items: + - const: vop-sys + - const: vop-vp0 + - const: vop-vp1 + - const: vop-vp2 required: - rockchip,grf - - rockchip,vo1-grf - - rockchip,vop-grf - rockchip,pmu - else: + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-vop + then: properties: - rockchip,vo1-grf: false - rockchip,vop-grf: false - rockchip,pmu: false - clocks: - maxItems: 5 + minItems: 7 clock-names: - maxItems: 5 - + minItems: 7 ports: required: - port@0 - port@1 - port@2 + - port@3 + required: + - rockchip,grf + - rockchip,vo1-grf + - rockchip,vop-grf + - rockchip,pmu additionalProperties: false