| Message ID | 20250107154755.2037197-1-jon.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: spi: rockchip-sfc: Add rockchip,fspi compatible | expand |
On 07/01/2025 16:47, Jon Lin wrote: > FSPI is an SFC upgrade IP that adds functions such as XIP. > > Signed-off-by: Jon Lin <jon.lin@rock-chips.com> > --- <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > > Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml > index ac1503de0478..4d64155d03f8 100644 > --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml > +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml > @@ -15,11 +15,15 @@ allOf: > > properties: > compatible: > - const: rockchip,sfc > + enum: > + - rockchip,fspi Don't grow generic patterns like that. Only SoC specific compatibles. > + - rockchip,sfc Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml index ac1503de0478..4d64155d03f8 100644 --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml @@ -15,11 +15,15 @@ allOf: properties: compatible: - const: rockchip,sfc + enum: + - rockchip,fspi + - rockchip,sfc + description: The rockchip sfc controller is a standalone IP with version register, and the driver can handle all the feature difference inside the IP depending on the version register. + The rockchip flexible spi controller is the next generation IP of sfc. reg: maxItems: 1
FSPI is an SFC upgrade IP that adds functions such as XIP. Signed-off-by: Jon Lin <jon.lin@rock-chips.com> --- Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)