From patchwork Wed Jan 8 11:52:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Yan X-Patchwork-Id: 13930865 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 406B1E77188 for ; Wed, 8 Jan 2025 12:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S1lKXmAUADTgLn12vU39N2glJQEfd8RKxhn8G6cKDf4=; b=lJThFSNu5E5XcT KCznh71WSOZyHPSn25jNEgFlY3QsfUs4UioS+N08mzozOLzXAJkYGsWH4zdSuUdqOaiQ3j/IzOT/D gFRYz+1WgFbUX31RdkHzoeMf2lci+16MkFwrbo+Uzos2vf7B/erBXYIMCf5SXcvfXn0IPGXMbVjAn EtOO7kllOkR8b/nWw7A6P2L7jHy+A+g+D2/AGCBnbkZDS1wos1zYgNOWGgf7m5My74Gv/E6fkMr7Z hTNKsHrivca0l16qcvn1nJdWaUvAFx9WJJhWAMU7KuuheHvgjQDjUUNzS4bRAnq54klRlcWsc/3IW wuzK1C/kGALThoVZRHAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVVQt-00000008TVR-2dfM; Wed, 08 Jan 2025 12:45:11 +0000 Received: from m16.mail.163.com ([220.197.31.4]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tVUcl-00000008Ix7-0EC2; Wed, 08 Jan 2025 11:53:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=Fb7Vt HZp4ZP+khwQrNOo4zrrHvRLsqIV0ZgKIF4ub3s=; b=GWy3ZByFEH468GsVN76MH PUsRkmkL6I+oD5D/nNHzsTc1E2WvBSLgx1CJIz0V+NPImfzR4assJ51wQ2dX3JA2 oS+Yu9Bf+uWFZPzmsfKeBrp+S6Capfzj24XvEqGL+S+I63QQh8jwqmCebCecvFpO 3Uq9wpmTVWG7Z3JBC4fb2I= Received: from ProDesk.. (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDHpyUCZ35n8Xn7EQ--.26804S12; Wed, 08 Jan 2025 19:52:50 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, krzk+dt@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, detlev.casanova@collabora.com, daniel@fooishbar.org, robh@kernel.org, Andy Yan Subject: [PATCH v9 10/11] dt-bindings: display: vop2: Add rk3576 support Date: Wed, 8 Jan 2025 19:52:27 +0800 Message-ID: <20250108115233.17729-11-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250108115233.17729-1-andyshrk@163.com> References: <20250108115233.17729-1-andyshrk@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wDHpyUCZ35n8Xn7EQ--.26804S12 X-Coremail-Antispam: 1Uf129KBjvJXoWxWr1kWFW5XryrGr4xJrWDurg_yoWrJry7pa 93Ca4DXrW8Gr1UWw1ktF1rCwn5tFn5Ar4Ykrn7ta17KrsIqr4UWw4agrn8Xr13Wry7Zaya 9FsYk343G392vr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UXa9fUUUUU= X-Originating-IP: [58.22.7.114] X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbB0h7OXmd+YSuOwAAAsB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250108_035323_448823_3DE7B6F6 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Andy Yan Add vop found on rk3576, the main difference between rk3576 and the previous vop is that each VP has its own interrupt line. Signed-off-by: Andy Yan --- Changes in v9: - Drop 'vop-' prefix of interrupt-names. - Add blank line between DT properties - Remove list interrupt-names in top level Changes in v8: - Fix dt_binding_check errors - ordered by soc name - Link to the previous version: https://lore.kernel.org/linux-rockchip/6pn3qjxotdtpzucpul24yro7ppddezwuizneovqvmgdwyv2j7p@ztg4mqyiqmjf/T/#u Changes in v4: - describe constraint SOC by SOC, as interrupts of rk3576 is very different from others - Drop Krzysztof's Reviewed-by, as this version changed a lot. Changes in v3: - ordered by soc name - Add description for newly added interrupt Changes in v2: - Add dt bindings .../display/rockchip/rockchip-vop2.yaml | 83 +++++++++++++++---- 1 file changed, 67 insertions(+), 16 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 2531726af306..44256cdcb877 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml @@ -20,6 +20,7 @@ properties: enum: - rockchip,rk3566-vop - rockchip,rk3568-vop + - rockchip,rk3576-vop - rockchip,rk3588-vop reg: @@ -37,10 +38,17 @@ properties: - const: gamma-lut interrupts: - maxItems: 1 + minItems: 1 + maxItems: 4 description: - The VOP interrupt is shared by several interrupt sources, such as - frame start (VSYNC), line flag and other status interrupts. + For VOP version under rk3576, the interrupt is shared by several interrupt + sources, such as frame start (VSYNC), line flag and other interrupt status. + For VOP version from rk3576 there is a system interrupt for bus error, and + every video port has it's independent interrupts for vsync and other video + port related error interrupts. + + interrupt-names: + maxItems: 4 # See compatible-specific constraints below. clocks: @@ -120,43 +128,86 @@ allOf: properties: compatible: contains: - const: rockchip,rk3588-vop + enum: + - rockchip,rk3566-vop + - rockchip,rk3568-vop then: properties: clocks: - minItems: 7 + minItems: 5 + clock-names: - minItems: 7 + minItems: 5 ports: required: - port@0 - port@1 - port@2 - - port@3 + + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3576-vop + then: + properties: + clocks: + minItems: 5 + + clock-names: + minItems: 5 + + ports: + required: + - port@0 + - port@1 + - port@2 + + interrupts: + items: + - description: vop system interrupt, such as axi bus error + - description: interrupts for video port0, such as vsync, dsp_hold. + - description: interrupts for video port1, such as vsync, dsp_hold. + - description: interrupts for video port2, such as vsync, dsp_hold. + + interrupt-names: + items: + - const: sys + - const: vp0 + - const: vp1 + - const: vp2 required: - rockchip,grf - - rockchip,vo1-grf - - rockchip,vop-grf - rockchip,pmu - else: + - if: + properties: + compatible: + contains: + const: rockchip,rk3588-vop + then: properties: - rockchip,vo1-grf: false - rockchip,vop-grf: false - rockchip,pmu: false - clocks: - maxItems: 5 + minItems: 7 + clock-names: - maxItems: 5 + minItems: 7 ports: required: - port@0 - port@1 - port@2 + - port@3 + + required: + - rockchip,grf + - rockchip,vo1-grf + - rockchip,vop-grf + - rockchip,pmu additionalProperties: false