| Message ID | 20250120-rk3588-spdif-v1-1-1415f5871dc7@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Add SPDIF on RK3588 | expand |
On Mon, Jan 20, 2025 at 01:01:27PM +0400, Alexey Charkov wrote: > Add a compatible string for SPDIF on RK3588, which is similar to the > one on RK3568. > > Signed-off-by: Alexey Charkov <alchark@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Hi Mark, Am Montag, 20. Januar 2025, 10:01:27 MEZ schrieb Alexey Charkov: > Add a compatible string for SPDIF on RK3588, which is similar to the > one on RK3568. > > Signed-off-by: Alexey Charkov <alchark@gmail.com> as the binding is more in the driver-realm, is this patch still somewhere on your radar? Thanks a lot Heiko > --- > Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml > index c3c989ef2a2c81eba73fae3d1ee4bfd18a8e5d29..32dea7392e8d49fc6402a64fc9f7115a47a8b8ad 100644 > --- a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml > +++ b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml > @@ -31,6 +31,10 @@ properties: > - rockchip,rk3288-spdif > - rockchip,rk3308-spdif > - const: rockchip,rk3066-spdif > + - items: > + - enum: > + - rockchip,rk3588-spdif > + - const: rockchip,rk3568-spdif > > reg: > maxItems: 1 > >
On Sun, Feb 09, 2025 at 10:10:47PM +0100, Heiko Stübner wrote: > Am Montag, 20. Januar 2025, 10:01:27 MEZ schrieb Alexey Charkov: > > Add a compatible string for SPDIF on RK3588, which is similar to the > > one on RK3568. > as the binding is more in the driver-realm, is this patch still > somewhere on your radar? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
Hi Mark, Am Montag, 10. Februar 2025, 14:20:58 MEZ schrieb Mark Brown: > On Sun, Feb 09, 2025 at 10:10:47PM +0100, Heiko Stübner wrote: > > Am Montag, 20. Januar 2025, 10:01:27 MEZ schrieb Alexey Charkov: > > > Add a compatible string for SPDIF on RK3588, which is similar to the > > > one on RK3568. > > > as the binding is more in the driver-realm, is this patch still > > somewhere on your radar? > > Please don't send content free pings and please allow a reasonable time > for review. People get busy, go on holiday, attend conferences and so > on so unless there is some reason for urgency (like critical bug fixes) > please allow at least a couple of weeks for review. If there have been > review comments then people may be waiting for those to be addressed. > > Sending content free pings adds to the mail volume (if they are seen at > all) which is often the problem and since they can't be reviewed > directly if something has gone wrong you'll have to resend the patches > anyway, so sending again is generally a better approach though there are > some other maintainers who like them - if in doubt look at how patches > for the subsystem are normally handled. With it being 3 weeks since the patch was originally posted, I thought it might be the time to ask if the binding-patch was still around. I vaguely do remember you saying in the past that if a patch hasn't been applied/handled after X time-units, it wouldn't be in your inbox anymore, but am not sure anymore ;-) .
On Mon, Feb 10, 2025 at 03:04:22PM +0100, Heiko Stübner wrote: > Am Montag, 10. Februar 2025, 14:20:58 MEZ schrieb Mark Brown: > > directly if something has gone wrong you'll have to resend the patches > > anyway, so sending again is generally a better approach though there are > > some other maintainers who like them - if in doubt look at how patches > > for the subsystem are normally handled. > With it being 3 weeks since the patch was originally posted, I thought > it might be the time to ask if the binding-patch was still around. > I vaguely do remember you saying in the past that if a patch hasn't > been applied/handled after X time-units, it wouldn't be in your inbox > anymore, but am not sure anymore ;-) . A big part of what that form letter is saying is that it's better to chase by resending since that ensures that if things have been lost the actual thing that you're looking for action on is right here. If you just send a ping either it'll get buried along with the original patch or there won't be information to hand.
diff --git a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml index c3c989ef2a2c81eba73fae3d1ee4bfd18a8e5d29..32dea7392e8d49fc6402a64fc9f7115a47a8b8ad 100644 --- a/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml +++ b/Documentation/devicetree/bindings/sound/rockchip-spdif.yaml @@ -31,6 +31,10 @@ properties: - rockchip,rk3288-spdif - rockchip,rk3308-spdif - const: rockchip,rk3066-spdif + - items: + - enum: + - rockchip,rk3588-spdif + - const: rockchip,rk3568-spdif reg: maxItems: 1
Add a compatible string for SPDIF on RK3588, which is similar to the one on RK3568. Signed-off-by: Alexey Charkov <alchark@gmail.com> --- Documentation/devicetree/bindings/sound/rockchip-spdif.yaml | 4 ++++ 1 file changed, 4 insertions(+)