From patchwork Sun Jan 25 20:52:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 5705711 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0BF01C058D for ; Sun, 25 Jan 2015 20:48:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F1553200E1 for ; Sun, 25 Jan 2015 20:48:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D4C8200DE for ; Sun, 25 Jan 2015 20:48:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YFU6H-0006bp-DG; Sun, 25 Jan 2015 20:48:05 +0000 Received: from gloria.sntech.de ([95.129.55.99]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YFU6F-0006ap-H7 for linux-rockchip@lists.infradead.org; Sun, 25 Jan 2015 20:48:04 +0000 Received: from ip923444a8.dynamic.kabel-deutschland.de ([146.52.68.168] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1YFU5o-0005d4-PR; Sun, 25 Jan 2015 21:47:36 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Daniel Lezcano Subject: Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288 Date: Sun, 25 Jan 2015 21:52:39 +0100 Message-ID: <2285293.ZBcGIuxxDo@diego> User-Agent: KMail/4.14.1 (Linux/3.16-3-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1422178979-12382-1-git-send-email-daniel.lezcano@linaro.org> References: <1422178979-12382-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150125_124803_746067_605514BA X-CRM114-Status: GOOD ( 16.61 ) X-Spam-Score: -0.0 (/) Cc: devicetree@vger.kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Daniel, one big request and some more style nitpicks :-) With the nitpicks fixed Reviewed-by: Heiko Stuebner Before applying this patch could you drop the rk3288.dtsi change please? Instead I'd like to add the following patch separately to _my_ devicetree branch for 3.20. I already wasn't fast enough to prevent the ethernet controller changes going through the network tree and would like to prevent a third tree sending changes for the same dts area to Linus - merge conflicts and all. I don't think that neither the nitpicks nor dropping the dtsi segment need another submission though. Heiko ----- 8< ----------- From: Daniel Lezcano Date: Sun, 25 Jan 2015 10:42:59 +0100 Subject: [PATCH] ARM: dts: rockchip: Add rockchip timer node for rk3288 The rk3288 board uses the architected timers and these ones are shutdown when the cpu is powered down. There is a need of a broadcast timer in this case to ensure proper wakeup when the cpus are in sleep mode and a timer expires. Add the timer node for the broadcast timer. Signed-off-by: Daniel Lezcano Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index c7235fa..37847c1 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -149,6 +149,14 @@ clock-frequency = <24000000>; }; + timer: timer@ff810000 { + compatible = "rockchip,rk3288-timer"; + reg = <0xff810000 0x20>; + interrupts = ; + clocks = <&xin24m>, <&cru PCLK_TIMER>; + clock-names = "timer", "pclk"; + }; + display-subsystem { compatible = "rockchip,display-subsystem"; ports = <&vopl_out>, <&vopb_out>;