[Bug] usb: dwc2: Add functions to set and clear force mode

Commit Message

John Youn Feb. 3, 2016, 12:03 a.m. UTC

On 2/1/2016 6:53 PM, Caesar Wang wrote:
> John,
> 
> I will suggest the msleep(25) delay should  put in 
> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()'
> 

Hi Caesar,

Are you saying that just msleep(25) in that function like this solves
your issue?


Although that is still not ideal, it's better than the alternative.

Regards,
John

Comments

Caesar Wang Feb. 3, 2016, 12:35 a.m. UTC | #1

Hi John,

? 2016?02?03? 08:03, John Youn ??:
> On 2/1/2016 6:53 PM, Caesar Wang wrote:
>> John,
>>
>> I will suggest the msleep(25) delay should  put in
>> 'dwc2_force_dr_mode()' instead of the 'dwc2_clear_force_mode()'
>>
> Hi Caesar,
>
> Are you saying that just msleep(25) in that function like this solves
> your issue?
>
> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
> index 39a0fa8..e8a9688 100644
> --- a/drivers/usb/dwc2/core.c
> +++ b/drivers/usb/dwc2/core.c
> @@ -625,6 +625,8 @@ void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg)
>                           __func__, hsotg->dr_mode);
>                  break;
>          }
> +
> +       msleep(25);

Yep, that will solve this issue.


>   }
>   
>
>
> Although that is still not ideal, it's better than the alternative.
>
> Regards,
> John
>
> -- 
> Thanks,
> Caesar

Patch

diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index 39a0fa8..e8a9688 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -625,6 +625,8 @@  void dwc2_force_dr_mode(struct dwc2_hsotg *hsotg)
                         __func__, hsotg->dr_mode);
                break;
        }
+
+       msleep(25);
 }